Fix isVaultRequest missing from PayPalLauncher app switch analytics events#1556
Merged
saralvasquez merged 2 commits intobraintree:mainfrom Mar 31, 2026
Merged
Conversation
…vents When app switch analytics were moved from PayPalClient to PayPalLauncher, the isVaultRequest param was not included in AnalyticsEventParams. This caused app-switch:started and app-switch:succeeded events to always report is_vault=false for vault/billing agreement flows, leading the o11y pipeline to misclassify them as ECS instead of vault. Made-with: Cursor
Contributor
saralvasquez
left a comment
saralvasquez
left a comment
There was a problem hiding this comment.
This makes sense and looks good to me. I see you added a happy path unit test which is great! Could you also add a unit test to verify the case when it's not a vault request and would have isVaultRequest false. Other than that it looks good to go in
Contributor
Author
Hi @saralvasquez , I updated the test case as per your request. |
agedd
approved these changes
Mar 31, 2026
Contributor
|
looks great — thanks for catching this and making the fix! feel free to merge whenever you're ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When app switch analytics were moved from PayPalClient to PayPalLauncher, the isVaultRequest param was not included in AnalyticsEventParams. This caused app-switch:started and app-switch:succeeded events to always report is_vault=false for vault/billing agreement flows, leading the o11y pipeline to misclassify them as ECS instead of vault.
Summary of changes
The fix passes isVaultRequest from PayPalPaymentAuthRequestParams (which already derives it from payPalRequest is PayPalVaultRequest) into the AnalyticsEventParams constructed in PayPalLauncher.launch().
Checklist
Authors