fix: correct ORCID and Google Scholar links in edit mode#99
Merged
Conversation
EditableText with type="url" was using the bare ID as href, causing the browser to resolve it as a relative path (e.g. /0000-0002-0829-4790→ 404). Added an optional `href` prop to EditableText so callers can supply the full URL independently from the display value, and passed the correct full URLs for ORCID (https://orcid.org/<id>) and Google Scholar (https://scholar.google.com/citations?user=<id>). Fixes #89 Co-authored-by: Satrajit Ghosh <satra@users.noreply.github.com>
Member
|
@satra Is it possible to enable some deployment previews for this project? Or is the backend too complicated for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditableText with type="url" was using the bare ID as href, causing the browser to resolve it as a relative path (e.g. /0000-0002-0829-4790 → 404).
Added an optional
hrefprop toEditableTextso callers can supply the full URL independently from the display value, and passed the correct full URLs for ORCID and Google Scholar.Fixes #89
Generated with Claude Code