Remove t_array to prevent duplicate times in dataset#346
Merged
dschwoerer merged 2 commits intomasterfrom Apr 28, 2026
Merged
Conversation
This is already handled in apply_geometry
Previously, this would only happen if "t" was in dims but not in coords, which could be legacy BOUT++ behaviour? Keeping two time arrays is asking for trouble.
Contributor
|
I am running the tests here with #345 merged into this, to enable tests on lazy loading: |
dschwoerer
approved these changes
Apr 28, 2026
Contributor
|
I think the remaining errors are due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #344
and boutproject/hermes-3#546