chore(aws-k8s): support authenticated dualstack ecr public pulls#4792
Open
mselim00 wants to merge 1 commit intobottlerocket-os:developfrom
Open
chore(aws-k8s): support authenticated dualstack ecr public pulls#4792mselim00 wants to merge 1 commit intobottlerocket-os:developfrom
mselim00 wants to merge 1 commit intobottlerocket-os:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A, but related to
Description of changes:
This updates the default credential provider configuration to support authentication for
ecr-public.aws.com, which is the dualstack endpoint for ECR public.Though the version of the
ecr-credential-providerincluded in the AMI may not support this authentication, or the node role may allow getting a public token, this is a safe change askubeletalways falls back to unauthenticated pulls if all credential providers fail. Releases are not yet cut with this change for 1.29-1.31, but the change is in their corresponding release branches.Testing done:
This was previously tested by Yutong for IPv4: #4396 (comment)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.