perf: fix parallel build race with header install#871
Merged
mgsharm merged 1 commit intobottlerocket-os:developfrom Mar 25, 2026
Merged
Conversation
Signed-off-by: Gaurav Sharma <mgsharm@amazon.com>
vigh-m
approved these changes
Mar 18, 2026
ytsssun
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The perf build has a race condition with high parallelism (-j128). In tools/perf/Makefile.perf, the libperf sub-build runs both libperf.a (compilation) and install_headers (copying headers to the output directory) as targets in a single parallel make invocation. The compiler's search path checks the output directory first, but the install command creates an empty file before writing the actual content. With -j128, the compiler can pick up that empty file before it's fully written, which causes incomplete type and missing prototype errors.
This adds a one-line patch to tools/lib/perf/Makefile that makes compilation depend on install_headers, ensuring all headers are fully installed before source files are compiled.
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.