Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .erb/configs/webpack.config.renderer.dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const configuration: webpack.Configuration = {
* NODE_ENV should be production so that modules do not perform certain
* development checks
*
* By default, use 'development' as NODE_ENV. This can be overriden with
* By default, use 'development' as NODE_ENV. This can be overridden with
* 'staging', for example, by changing the ENV variables in the npm scripts
*/
new webpack.EnvironmentPlugin({
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ Set the "version" parameter in the release/app/package.json's "version".

## Release

Github release drafts are created whenever main is updated and there is no existing version found in release/app/package.json's "version".
GitHub release drafts are created whenever main is updated and there is no existing version found in release/app/package.json's "version".

See the .env.example file for more information about what is needed for release (everything not written _DEV, or CI). You'll need to add these as secrets on Github repo. Note that despite the fact that Electron-builder's CSC_LINK and WIN_CSC_LINK ask for links, you can also convert your code signing certificates into base64 and use the strings.
See the .env.example file for more information about what is needed for release (everything not written _DEV, or CI). You'll need to add these as secrets on GitHub repo. Note that despite the fact that Electron-builder's CSC_LINK and WIN_CSC_LINK ask for links, you can also convert your code signing certificates into base64 and use the strings.


## A bit about versioning
Expand Down
2 changes: 1 addition & 1 deletion src/main/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ app.on('will-quit', () => {

app.on('window-all-closed', () => {
trackEvent('windowAllClosed');
// Respect the OSX convention of having the application in memory even
// Respect the macOS convention of having the application in memory even
// after all windows have been closed
if (process.platform !== 'darwin') {
app.quit();
Expand Down