Suppress "Current WiFi is not allowed" notification for scheduled backups#2444
Open
aniketgit-hub101 wants to merge 2 commits intoborgbase:masterfrom
Open
Suppress "Current WiFi is not allowed" notification for scheduled backups#2444aniketgit-hub101 wants to merge 2 commits intoborgbase:masterfrom
aniketgit-hub101 wants to merge 2 commits intoborgbase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suppresses the error notification when a scheduled backup is skipped
because the current WiFi network is not allowed. This is intentional
behavior, not an error, so users should not receive an error
notification in this case.
Related Issue
Fixes #2231
Motivation and Context
When a user marks a WiFi network as disallowed, Vorta correctly skips
the backup. However, it was still sending an error notification saying
"Current WiFi is not allowed" — which is confusing since this is
expected behavior, not a failure.
The fix adds a check in the create_backup() method in scheduler.py
to suppress the notification when the message indicates WiFi is not
allowed.
How Has This Been Tested?
Code review confirms the notification delivery is now conditional on
the message not being WiFi-related. No functional change to backup
behavior — only the notification is suppressed.
Types of changes
Checklist: