Fix #1080: prevent crash when removing source during size recalculation#2435
Open
ebuzerdrmz44 wants to merge 1 commit intoborgbase:masterfrom
Open
Fix #1080: prevent crash when removing source during size recalculation#2435ebuzerdrmz44 wants to merge 1 commit intoborgbase:masterfrom
ebuzerdrmz44 wants to merge 1 commit intoborgbase:masterfrom
Conversation
Guard against race condition where FilePathInfoAsync thread completes after the source has been removed. Disconnect thread signals on removal and catch DoesNotExist in the callback as a safety net.
ebuzerdrmz44
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a source is removed while its size is being recalculated, disconnect the
running thread's signal and add a
DoesNotExistguard inset_path_infofor caseswhere the signal was already queued before disconnection.
Related Issue
#1080
Motivation and Context
Removing a source while its size is being recalculated causes the app to crash
with
QThread: Destroyed while thread is still running. This happens becausethe thread completes and tries to call
set_path_infoafter the source hasalready been deleted.
How Has This Been Tested?
Tested manually:
Unit tests: 189 passed, 6 skipped, 0 failed.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: