Fix #2414: Add ExclusionModel support to profile export#2434
Fix #2414: Add ExclusionModel support to profile export#2434Sayeem3051 wants to merge 1 commit intoborgbase:masterfrom
Conversation
Added ExclusionModel handling to profile export and database methods.
|
This looks better, but you sniped the issue away from someone else who asked to work on it properly. So we'll give him time to come up with their own PR. If they end up not working on it, we can consider this. Working on an open source project also includes understanding the context and working with other contributors. It's not that the fastest will win. |
|
Thank you for the feedback, @m3nu. I understand and completely agree - I should have checked the issue context more carefully before working on it. I see now that someone else had already asked to work on this issue. I apologize for jumping ahead without consulting with the community first. You're absolutely right that collaboration and understanding the context is important in open source projects. It's not about speed, but about being a good team member and respecting others' contributions. I'll close this PR and let the other contributor have the opportunity to work on it. If they don't end up completing it, I'd be happy to contribute then. Thank you for the learning opportunity - I'll make sure to check issue discussions and be more thoughtful about picking up issues in the future. |
Added ExclusionModel handling to profile export and database methods.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.