Fix #2414: Add ExcludeModel to export and fix missing excludes list#2431
Fix #2414: Add ExcludeModel to export and fix missing excludes list#2431abubakarsabir924-cell wants to merge 4 commits intoborgbase:masterfrom
Conversation
|
I've updated the code. |
|
Hi @m3nu sir, just a gentle reminder about my PR. I would really appreciate your feedback. The application deadline is approaching, so your guidance would really help me improve. Thank you! |
Code reviewFound 1 issue:
vorta/src/vorta/profile_export.py Lines 66 to 71 in f7ef0cc Also note: the model class is named |
|
Thanks for the detailed review, @m3nu sir |
|
You're lucky #2434 has just as many issues. I also don't understand how you produce such basic errors with AI, tests and linters. All of those should have caught them. |
Description
Summary
This PR fixes issue #2414 where the excludes list was missing in exported settings.
Changes
Added ExcludeModel to profile_export.py
Ensured excludes list is properly included in export
Fixed related import issues
Testing
Verified that excludes list is now included in exported settings
Tested export functionality to ensure no regressions
Notes
This PR is now ready for review. Feedback is highly appreciated.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.