Fix issue #1815: Add delay before running catch-up backups after resume#2427
Open
Sayeem3051 wants to merge 3 commits intoborgbase:masterfrom
Open
Fix issue #1815: Add delay before running catch-up backups after resume#2427Sayeem3051 wants to merge 3 commits intoborgbase:masterfrom
Sayeem3051 wants to merge 3 commits intoborgbase:masterfrom
Conversation
…ter resume When the system resumes from sleep/suspend, the scheduler immediately triggers catch-up backups if any scheduled runs were missed during the sleep period. This can cause errors if system services (NetworkManager, DBus) are not yet fully initialized. This fix adds a 30-second delay using QtCore.QTimer.singleShot() before executing the catch-up backup, giving the system time to fully restore network state and services. Fixes borgbase#1815
…gleShot() call was incorrectly dedented outside the try block, causing a SyntaxError (expected 'except' or 'finally' block). This broke scheduler.py parsing and prevented the module from loading. Moved the line to proper indentation inside the try block so the delayed backup logic can execute correctly.
Author
|
@chatgpt-codex-connector Thank you for catching that critical indentation error! 🎯 I've fixed the issue with commit 770f56a:
The fix maintains the intended behavior: Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the system resumes from sleep/suspend, the scheduler immediately triggers catch-up backups if any scheduled runs were missed during the sleep period. This can cause errors if system services (NetworkManager, DBus) are not yet fully initialized.
This fix adds a 30-second delay using QtCore.QTimer.singleShot() before executing the catch-up backup, giving the system time to fully restore network state and services.
Fixes #1815
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.