Show warning when changing repository with existing backups#2421
Open
Justaanand50 wants to merge 1 commit intoborgbase:masterfrom
Open
Show warning when changing repository with existing backups#2421Justaanand50 wants to merge 1 commit intoborgbase:masterfrom
Justaanand50 wants to merge 1 commit intoborgbase:masterfrom
Conversation
This was referenced Mar 13, 2026
Fixes borgbase#1714 - Added a QMessageBox confirmation dialog when user attempts to change the repository in a profile that already has existing backups. User can confirm or cancel, reverting to the previous repository selection if cancelled.
Author
|
Hi! I wanted to follow up on this PR. I'm applying for GSoC 2026 with PSF and this is part of my contribution to Vorta. Would love any feedback or review when you get a chance! |
Justaanand50
force-pushed
the
fix/repo-change-warning
branch
from
95b526c to
86ce762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a QMessageBox confirmation dialog when user attempts to change the repository in a profile that already has existing backups. User can confirm or cancel, reverting to the previous repository selection if cancelled.
Description
When a user changes the repository dropdown in a profile that already has existing backups, a warning dialog now appears asking them to confirm the change. If they click No, the dropdown reverts to the previously selected repository.
Related Issue
Fixes #1714
Motivation and Context
Previously there was no warning when changing repositories, which could cause users to accidentally backup to the wrong repository without realizing it. This is especially problematic for users with multiple profiles and repositories.
How Has This Been Tested?
Manually tested by creating a profile with an existing repository and attempting to change it. Confirmed the warning dialog appears correctly and reverts the selection when user clicks No.
Types of changes
Checklist