Add --fail-on-violation flag to exit non-zero when violations are detected#392
Open
mbarbero wants to merge 1 commit intoboostsecurityio:mainfrom
Open
Add --fail-on-violation flag to exit non-zero when violations are detected#392mbarbero wants to merge 1 commit intoboostsecurityio:mainfrom
mbarbero wants to merge 1 commit intoboostsecurityio:mainfrom
Conversation
Contributor
|
Thanks for your contribution @mbarbero ! Could you fix the lint please? |
…ected poutine always exited with code 0 after analysis, even when violations were found, making it unsuitable for use as a blocking CI gate. This adds an opt-in --fail-on-violation flag that exits with code 10 when violations are detected. Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Signed-off-by: Mikaël Barbero <mikael.barbero@eclipse-foundation.org>
mbarbero
force-pushed
the
add-fail-on-violation
branch
from
3de2f42 to
d0e5208
Compare
Author
|
linter issues are fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poutine always exited with code 0 after analysis, even when violations were found, making it unsuitable for use as a blocking CI gate. This adds an opt-in
--fail-on-violationflag that exits with code 10 when violations are detected.Fixes #391