Change back() method to iterator for 1450#1451
Merged
barendgehrels merged 2 commits intoboostorg:developfrom Feb 25, 2026
Merged
Change back() method to iterator for 1450#1451barendgehrels merged 2 commits intoboostorg:developfrom
barendgehrels merged 2 commits intoboostorg:developfrom
Conversation
The issue is about absence of back() method in a ring. This commit solves the issue using different approach: such behavior is achieved using iterator difference by 1.
Contributor
Author
|
All tests were passed successfully |
barendgehrels
approved these changes
Feb 24, 2026
Chaned ring.back() to *(boost::end(ring) - 1) and then to range::back(ring)
mloskot
approved these changes
Feb 24, 2026
Member
|
FYI, I let the workflows run I haven't been active in the library maintenance for quite some time now, but I chimed in out of curiosity being suspicious the issue may be due to regression in Boost.Iterator in 1.89, which is not, obviously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is about absence of back() method in a ring. This commit solves the issue using different approach: such behavior is achieved using iterator difference by 1.