Implement multipart/form-data file upload support using busboy#12
Open
Robert0303-C wants to merge 1 commit intobogeeee:mainfrom
Open
Implement multipart/form-data file upload support using busboy#12Robert0303-C wants to merge 1 commit intobogeeee:mainfrom
Robert0303-C wants to merge 1 commit intobogeeee:mainfrom
Conversation
- Add busboy and @types/busboy as dependencies - Implement multipart/form-data parsing with proper security limits: - MAX_FILE_SIZE: 100MB per file - MAX_FILES: 10 files max - MAX_FIELDS: 100 fields max - MAX_TOTAL_PARTS: 1000 parts max - MAX_HEADER_PAIRS: 2000 header pairs max - Make collectParamsFromRequest async to support await for Promise-based parsing - Extract fields and files from multipart body and pass to convertAndAddParams - Files are stored as UploadFile objects with createReadStream method - Handle multiple values for same field name - Proper error handling with CommunicationError wrapper
Author
|
/claim #6 |
|
👀 We've notified the reward creators here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements multipart/form-data file upload support using the busboy library.
Changes
collectParamsFromRequestasync to support await for Promise-based parsingconvertAndAddParamscreateReadStreammethodSecurity
The implementation includes multiple security limits to prevent DoS attacks:
Notes
CommunicationErrorwith message "multipart/form-data file uploads not yet implemented"createReadStreamFixes #6