Skip to content

🛡️ Sentinel: [CRITICAL] Fix XSS in DescriptionPreview#21

Open
bobdivx wants to merge 1 commit intodevfrom
sentinel/xss-fix-description-preview-6825468937015453122
Open

🛡️ Sentinel: [CRITICAL] Fix XSS in DescriptionPreview#21
bobdivx wants to merge 1 commit intodevfrom
sentinel/xss-fix-description-preview-6825468937015453122

Conversation

@bobdivx
Copy link
Copy Markdown
Owner

@bobdivx bobdivx commented Mar 19, 2026

🚨 Severity: CRITICAL
💡 Vulnerability: The DescriptionPreview component used dangerouslySetInnerHTML to render HTML descriptions received from the backend (or parsed from BBCode) without sufficient sanitization. It only removed literal {} characters.
🎯 Impact: This made it trivial for an attacker to inject malicious scripts (e.g., <script>alert(1)</script>) via the description field, leading to a Cross-Site Scripting (XSS) vulnerability.
🔧 Fix: Imported and applied isomorphic-dompurify (to support both SSR and CSR securely in Astro/Preact) to sanitize the HTML string before passing it to dangerouslySetInnerHTML. Updated the .jules/sentinel.md journal to document this architectural security gap and prevention strategy.
Verification: Verified that building (npm run build) and testing (npm run test) pass. Further verified via a short Node rendering script that malicious script tags are stripped before they ever hit the DOM.


PR created automatically by Jules for task 6825468937015453122 started by @bobdivx

Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
popcorn-client Ready Ready Preview, Comment Mar 19, 2026 7:28am

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical XSS vulnerability within the DescriptionPreview component. Previously, the component rendered HTML descriptions without adequate sanitization, allowing for potential malicious script injection. The solution involves integrating isomorphic-dompurify to rigorously sanitize all incoming HTML, thereby securing the application against XSS attacks and ensuring safe content rendering across both server-side and client-side environments.

Highlights

  • Critical XSS Vulnerability Fixed: Addressed a critical Cross-Site Scripting (XSS) vulnerability in the DescriptionPreview component.
  • HTML Sanitization Implemented: Integrated isomorphic-dompurify to rigorously sanitize HTML content before rendering, effectively preventing malicious script injection.
  • Security Documentation Updated: Documented the architectural security gap and the new prevention strategy in the .jules/sentinel.md journal.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses a critical Cross-Site Scripting (XSS) vulnerability by integrating isomorphic-dompurify for robust HTML sanitization. The introduction of DOMPurify.sanitize() within the sanitizePreviewHtml function is a crucial step in preventing malicious script injection. The accompanying documentation in .jules/sentinel.md clearly outlines the vulnerability, the lessons learned, and the prevention strategy, which is excellent for maintaining security awareness. The dependency updates in package.json and package-lock.json correctly reflect the addition of the new sanitization library. Overall, this is a well-executed and important security fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant