Skip to content

🛡️ Sentinel: [HIGH] Fix XSS vulnerability in DescriptionPreview#16

Open
bobdivx wants to merge 1 commit intodevfrom
sentinel-fix-xss-dompurify-17173046131014348472
Open

🛡️ Sentinel: [HIGH] Fix XSS vulnerability in DescriptionPreview#16
bobdivx wants to merge 1 commit intodevfrom
sentinel-fix-xss-dompurify-17173046131014348472

Conversation

@bobdivx
Copy link
Copy Markdown
Owner

@bobdivx bobdivx commented Mar 14, 2026

🛡️ Sentinel: [HIGH] Fix XSS vulnerability in DescriptionPreview

🚨 Severity: HIGH
💡 Vulnerability: User input and BBCode-to-HTML converted data from trackers was being passed directly to dangerouslySetInnerHTML in src/components/upload/DescriptionPreview.tsx without sanitization, leading to an XSS vulnerability.
🎯 Impact: An attacker could inject malicious scripts through torrent descriptions, potentially compromising user sessions or executing arbitrary code in the context of the application.
🔧 Fix: Installed isomorphic-dompurify and applied DOMPurify.sanitize() to the HTML before rendering it via dangerouslySetInnerHTML. The isomorphic version was chosen to ensure safe execution across both SSR (Node.js) and CSR (Browser).
✅ Verification: Build succeeds, tests pass, and manual review confirms sanitization is applied. Added a critical learning to .jules/sentinel.md.


PR created automatically by Jules for task 17173046131014348472 started by @bobdivx

🚨 Severity: HIGH
💡 Vulnerability: User input and BBCode-to-HTML converted data from trackers was being passed directly to `dangerouslySetInnerHTML` in `src/components/upload/DescriptionPreview.tsx` without sanitization, leading to an XSS vulnerability.
🎯 Impact: An attacker could inject malicious scripts through torrent descriptions, potentially compromising user sessions or executing arbitrary code in the context of the application.
🔧 Fix: Installed `isomorphic-dompurify` and applied `DOMPurify.sanitize()` to the HTML before rendering it via `dangerouslySetInnerHTML`. The isomorphic version was chosen to ensure safe execution across both SSR (Node.js) and CSR (Browser).
✅ Verification: Build succeeds, tests pass, and manual review confirms sanitization is applied. Added a critical learning to `.jules/sentinel.md`.

Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
popcorn-client Ready Ready Preview, Comment Mar 14, 2026 7:22am

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a critical security update by patching a high-severity XSS vulnerability. It introduces robust HTML sanitization to prevent malicious code from being executed when displaying user-generated content, thereby significantly enhancing the application's security posture and protecting users from potential attacks.

Highlights

  • Security Fix: XSS Vulnerability: Addressed a high-severity Cross-Site Scripting (XSS) vulnerability in the DescriptionPreview component where unsanitized user input and BBCode-to-HTML converted data were rendered directly, allowing malicious script injection.
  • HTML Sanitization Implementation: Integrated isomorphic-dompurify to sanitize HTML content before it is rendered using dangerouslySetInnerHTML. This ensures that potentially malicious scripts are removed, protecting user sessions and application integrity.
  • Isomorphic Solution for SSR/CSR: Selected isomorphic-dompurify to guarantee consistent and secure sanitization across both server-side rendering (SSR) and client-side rendering (CSR) environments, preventing issues with window object dependencies.
  • Documentation of Learning: A new entry was added to .jules/sentinel.md to document the vulnerability, the learning derived from its fix, and best practices for preventing similar issues in Astro/Preact applications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .astro/content.d.ts
    • Updated the import path for ContentConfig to use a relative path.
  • .astro/types.d.ts
    • Added a reference to content.d.ts to ensure proper type declarations.
  • .jules/sentinel.md
    • Added a new entry detailing the XSS vulnerability in DescriptionPreview.tsx, the learning from using isomorphic-dompurify for SSR/CSR, and prevention guidelines.
  • package-lock.json
    • Added isomorphic-dompurify and @types/dompurify as new dependencies.
    • Updated versions for several existing dependencies, including @asamuzakjp/dom-selector, @exodus/bytes, and undici.
    • Removed dev: true flags from numerous dependency entries, indicating a change in their development status or how they are tracked.
  • package.json
    • Added isomorphic-dompurify as a production dependency.
    • Added @types/dompurify as a development dependency.
  • public/VERSION.json
    • Incremented the client version from 1.2.97 to 1.2.98.
    • Incremented the client build number from 198 to 199.
  • src/components/upload/DescriptionPreview.tsx
    • Imported DOMPurify from isomorphic-dompurify.
    • Modified the sanitizePreviewHtml function to apply DOMPurify.sanitize() to the HTML string after removing residual placeholders, effectively preventing XSS.
Activity
  • The pull request was automatically created by Jules for task 17173046131014348472, initiated by @bobdivx.
  • Verification steps confirmed that the build succeeds, tests pass, and manual review validated the applied sanitization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a high-severity XSS vulnerability in the DescriptionPreview component by sanitizing HTML with isomorphic-dompurify before rendering. The approach is sound, and the addition of a security learning document is a great practice. I have one minor suggestion to improve code conciseness.

Comment on lines +11 to +12
const cleanedHtml = html.replace(/\{\}/g, '');
return DOMPurify.sanitize(cleanedHtml);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For conciseness, you can chain the replace and sanitize calls. This avoids creating an intermediate variable.

Suggested change
const cleanedHtml = html.replace(/\{\}/g, '');
return DOMPurify.sanitize(cleanedHtml);
return DOMPurify.sanitize(html.replace(/\{\}/g, ''));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant