fix(pg-register-service): musl compat, service name, and service path#36
Open
fix(pg-register-service): musl compat, service name, and service path#36
Conversation
…name, correct service path - Drop @0.x version constraint from serviceman install URL — libc detection mismatch causes failure on Alpine/musl systems. - Rename service from postgres-as-$USER to postgres on Linux, matching macOS behavior. - Detect init system (OpenRC vs systemd vs launchd) to print the correct service file path instead of hardcoding the systemd path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@0.xversion constraint from the serviceman install URL — libc detection mismatch causes install failure on Alpine/musl systems.postgres-as-$USERtopostgreson Linux, matching the macOS behavior./etc/systemd/system/.Test plan
pg-register-service 5432on Alpine (OpenRC) — verify serviceman installs and output shows/etc/init.d/postgrespg-register-service 5432on Ubuntu/Debian (systemd) — verify output shows/etc/systemd/system/postgres.servicepg-register-service 5432on macOS — verify output shows~/Library/LaunchAgents/postgres.plist