Remove bmlt.virtual-na.org virtual root support#453
Merged
Conversation
The Virtual NA root was the sole entry in VirtualRoots.ts and required a parallel code path that queried the root server directly since virtual servers weren't catalogued by the Aggregator. Dropping it lets tally rely exclusively on the Aggregator and removes a chunk of dead scaffolding. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pjaudiomv
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/lib/VirtualRoots.ts— Virtual NA was its only entry.getVirtualRootsDetailscode path fromservices.ts; tally now relies exclusively on the Aggregator.id?: stringfield on theRoottype and the README sentence pointing atVirtualRoots.ts.Test plan
npm run checkpassesnpm run buildsucceedsnpm run dev— table, reports, and map views render; the "Virtual NA" row is no longer present and server/meeting counts reflect Aggregator-only data🤖 Generated with Claude Code