Skip to content

Prevent composition from being destroyed when participating in AndroidX transition #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oleksandr-semenov wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Prevent composition from being destroyed when participating in AndroidX transition #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ...ctor/src/main/java/com/bluelinelabs/conductor/internal/OwnViewTreeLifecycleAndRegistry.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ internal class OwnViewTreeLifecycleAndRegistry private constructor(

private var hasSavedState = false
private var savedRegistryState = Bundle.EMPTY
private var isControllerChangeInProgress: Boolean = false

override val lifecycle: LifecycleRegistry
get() = lifecycleRegistry

Expand Down Expand Up @@ -75,6 +77,8 @@ internal class OwnViewTreeLifecycleAndRegistry private constructor(
changeHandler: ControllerChangeHandler,
changeType: ControllerChangeType
) {
isControllerChangeInProgress = false

// Should only happen if pushing another controller over this one was aborted
if (
controller === changeController &&
Expand All @@ -85,13 +89,26 @@ internal class OwnViewTreeLifecycleAndRegistry private constructor(
) {
lifecycleRegistry.handleLifecycleEvent(Lifecycle.Event.ON_RESUME)
}

// View is not required anymore we can destroy the lifecycle
if (
controller === changeController &&
changeType == ControllerChangeType.PUSH_EXIT &&
changeHandler.removesFromViewOnPush &&
changeController.view?.windowToken != null &&
lifecycleRegistry.currentState.isAtLeast(Lifecycle.State.STARTED)
) {
lifecycleRegistry.handleLifecycleEvent(Lifecycle.Event.ON_DESTROY)
}
}

override fun onChangeStart(
changeController: Controller,
changeHandler: ControllerChangeHandler,
changeType: ControllerChangeType,
) {
isControllerChangeInProgress = true

pauseOnChangeStart(
targetController = controller,
changeController = changeController,
Expand Down Expand Up @@ -135,9 +152,11 @@ internal class OwnViewTreeLifecycleAndRegistry private constructor(
lifecycleRegistry.handleLifecycleEvent(Lifecycle.Event.ON_DESTROY)
}
})
} else {
} else if (!isControllerChangeInProgress) {
// View is still can be used by change handlers
lifecycleRegistry.handleLifecycleEvent(Lifecycle.Event.ON_DESTROY)
}

}

override fun postContextAvailable(controller: Controller, context: Context) {
Expand Down