Skip to content

Enable sqllogfill by default #5758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markhannum wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Enable sqllogfill by default #5758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db/db_tunables.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1422,7 +1422,7 @@ REGISTER_TUNABLE("apply_pollms",
"Apply-thread poll time before checking queue. "
"(Default: 100ms)",
TUNABLE_INTEGER, &gbl_apply_thread_pollms, EXPERIMENTAL | INTERNAL, NULL, NULL, NULL, NULL);
REGISTER_TUNABLE("sql_logfill", "Request transaction logs via sql thread. (Default: off)", TUNABLE_BOOLEAN,
REGISTER_TUNABLE("sql_logfill", "Request transaction logs via sql thread. (Default: on)", TUNABLE_BOOLEAN,
&gbl_sql_logfill, READONLY, NULL, NULL, NULL, NULL);
REGISTER_TUNABLE("sql_logfill_debug", "Enable extended trace for sql logfill thread. (Default: off)", TUNABLE_BOOLEAN,
&gbl_debug_sql_logfill, 0, NULL, NULL, NULL, NULL);
Expand Down
2 changes: 1 addition & 1 deletion db/sqllogfill.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#define TRANLOG_FLAGS_SENTINEL 0x08 /* Return sentinel for missing record */

/* Tunables */
int gbl_sql_logfill = 0;
int gbl_sql_logfill = 1;
int gbl_debug_sql_logfill = 0;
int gbl_sql_logfill_stats = 1;
int gbl_sql_logfill_dedicated_apply_thread = 0;
Expand Down
2 changes: 1 addition & 1 deletion tests/tunables.test/t00_all_tunables.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@
(name='sosql_poke_timeout_sec', description='On replicants, when checking on master for transaction status, retry the check after this many seconds.', type='INTEGER', value='60', read_only='N')
(name='spfile', description='', type='STRING', value=NULL, read_only='Y')
(name='sql_close_sbuf', description='sql_close_sbuf', type='BOOLEAN', value='OFF', read_only='N')
(name='sql_logfill', description='Request transaction logs via sql thread. (Default: off)', type='BOOLEAN', value='OFF', read_only='Y')
(name='sql_logfill', description='Request transaction logs via sql thread. (Default: on)', type='BOOLEAN', value='ON', read_only='Y')
(name='sql_logfill_apply_thread', description='Use a dedicated thread to apply sql logfills. (Default: off)', type='BOOLEAN', value='OFF', read_only='Y')
(name='sql_logfill_debug', description='Enable extended trace for sql logfill thread. (Default: off)', type='BOOLEAN', value='OFF', read_only='N')
(name='sql_logfill_lookahead_records', description='Max lookahead records cached for dedicated apply thread. (Default: 10000)', type='INTEGER', value='10000', read_only='Y')
Expand Down