CI: Use BlazingMQ broker docker image#83
Open
pniedzielski wants to merge 2 commits intobloomberg:mainfrom
Open
CI: Use BlazingMQ broker docker image#83pniedzielski wants to merge 2 commits intobloomberg:mainfrom
pniedzielski wants to merge 2 commits intobloomberg:mainfrom
Conversation
pniedzielski
force-pushed
the
ci/docker
branch
8 times, most recently
from
ed3c2b1 to
0d0eaf2
Compare
Collaborator
Author
|
Once we get libbmq vcpkg'd, we won't need to build BDE, NTF, or libbmq, except to build wheels. |
This patch changes the test CI workflow to pull the latest BlazingMQ
Docker image for running tests with, rather than running the broker
that we built from scratch. There’s a few different concerns here
when making this change:
- Pulling the Docker images requires us to log in to GHCR. To avoid
accidentally (or maliciously) pushing a Docker image while we’re
logged in, we give up the write permissions from our login token.
- Rather than broker logs being interleaved with test failures, we
have to pull them ourselves from the Docker container.
- Because we’re running exactly the broker from GHCR, and we print
which version we’re running, we can pull that exact Docker image
locally rather than uploading the broker binary as an artifact.
- We need to update some of our test broker configuration to work
nicely in the Docker image, which mostly involves changing some
file paths.
Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
This patch removes bmqbrkr from our CI build, since we use the bmqbrkr docker image now. We are safe to do this even though these scripts are used when building wheels as well, since wheel builds do not need the broker either. Additionally, this patch removes mwc from the install targets, since it no longer exists. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we publish a BlazingMQ broker docker image, we don't need to compile the whole broker in CI. This PR changes our CI to only build libbmq, and pull the broker from GHCR.