Merged
Conversation
Contributor
Author
|
Very nice Found a linting issue, will fix. |
| import kotlin.test.assertTrue | ||
|
|
||
| class FeeEstimateEndpointTest { | ||
| class HistoricalFeeEstimateEndpointTest { |
Contributor
Author
There was a problem hiding this comment.
This caused gradle build to fail locally:
> Task :app:compileTestKotlin FAILED
e: file:////Development/augur/bitcoin-augur-reference/app/src/test/kotlin/xyz/block/augurref/api/FeeEstimateEndpointTest.kt:46:7 Redeclaration:
class FeeEstimateEndpointTest : Any
e: file:///Development/augur/bitcoin-augur-reference/app/src/test/kotlin/xyz/block/augurref/api/HistoricalFeeEstimateEndpointTest.kt:43:7 Redeclaration:
class FeeEstimateEndpointTest : Any
[Incubating] Problems report is available at: file:///Development/augur/bitcoin-augur-reference/build/reports/problems/problems-report.html
oliver-unblocked
force-pushed
the
github_actions
branch
from
4843462 to
17336d5
Compare
Contributor
|
ACK 17336d5 looks good to me and fixes tests! |
laurenshareshian
approved these changes
Aug 19, 2025
Collaborator
laurenshareshian
left a comment
laurenshareshian
left a comment
There was a problem hiding this comment.
Thanks for this 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
Replaces #10