Fix ModuleClientMeta passing row ID instead of module ID#12
Open
mendozal wants to merge 1 commit intoblesta:masterfrom
Open
Fix ModuleClientMeta passing row ID instead of module ID#12mendozal wants to merge 1 commit intoblesta:masterfrom
mendozal wants to merge 1 commit intoblesta:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a service, the module was always attempting to create a new customer in Enhance even when one already existed for the client, resulting in a
409 Login already existserror from the Enhance API.ModuleClientMeta::get()andset()signatures are:All calls in
enhance.phpwere passing$row->idas themodule_idparameter. However,$rowis the object returned bygetModuleRow(), which queries themodule_rowstable — so$row->idis the module row primary key, not the module ID. The correct value is$row->module_id.This mismatch caused
get()to never find stored customer data, andset()to store it under the wrong module ID, making it permanently unfindable.Fix
Replaced
$row->idwith$row->module_idin all 5 affected instances:addService()—ModuleClientMeta->get()x2 andModuleClientMeta->set()x1tabChangePassword()—ModuleClientMeta->get()x1tabClientChangePassword()—ModuleClientMeta->get()x1Note for existing installations
Any records already stored in
module_client_metawith the wrongmodule_idwill need to be corrected manually in the database: