Skip to content

feat: read ESTELA_SPIDER_ARGS from environment #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquingx merged 1 commit into from
Mar 3, 2026
Merged

feat: read ESTELA_SPIDER_ARGS from environment #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions estela_requests/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
settings_files= settings_files_list,
)

print("Settings file list: %s" % settings_files_list)
print(f"Settings file list: {settings_files_list}")
sett_as_dict = settings.as_dict()
print("Settings obtained: %s" % sett_as_dict)
print(f"Settings obtained: {sett_as_dict}")
2 changes: 1 addition & 1 deletion estela_requests/middlewares/tests/test_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def test_after_session_updates_stats_correctly(self):
assert middleware.stats['downloader/request_count'] == 0
assert middleware.stats['response_received_count'] == 0

def test_after_session_updates_stats_correctly(self):
def test_before_session_sets_start_time(self):
producer = Mock(spec=ProducerInterface)
topic = 'test_topic'
metadata = {'jid': 'test_job'}
Expand Down
2 changes: 1 addition & 1 deletion estela_requests/request_interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ def request(self, *args, **kwargs):
class RequestsInterface(HttpRequestInterface):

def request(self, *args, **kwargs):
return requests.request(*args, **kwargs)
return requests.request(*args, **kwargs) # noqa: S113
3 changes: 2 additions & 1 deletion estela_requests/settings_remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
import os

from estela_queue_adapter.get_interface import get_producer_interface

Expand All @@ -13,7 +14,7 @@
HTTP_CLIENT = RequestsInterface()
ESTELA_API_HOST = "http://127.0.0.1"
ESTELA_SPIDER_JOB = "101.madbymike.4796d37b-698b-4684-83c8-e3763c8d32ba"
ESTELA_SPIDER_ARGS = ""
ESTELA_SPIDER_ARGS = os.environ.get("ESTELA_SPIDER_ARGS", "")
ESTELA_ITEM_PIPELINES = []
ESTELA_ITEM_EXPORTERS = [KafkaItemExporter]
ESTELA_LOG_LEVEL = logging.DEBUG
Expand Down