DmfsTask: implement descriptive field handlers#435
Open
sunkup wants to merge 9 commits into
Open
Conversation
sunkup
added
refactoring
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors DmfsTaskProcessor to map additional “descriptive” dmfs task columns via dedicated DmfsTaskFieldHandler implementations, aligning the task-mapping approach more closely with the existing handler-based mapping patterns in the codebase.
Changes:
- Added field handlers for task
DESCRIPTION,LOCATION,GEO,TASK_COLOR,URL, andORGANIZER. - Updated
DmfsTaskProcessor.populateTask()to use the new handlers instead of inline mapping logic. - Added Robolectric unit tests for each new handler.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/DmfsTaskProcessor.kt | Wires the new field handlers into task row → Task mapping and removes the previous inline implementations. |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/handler/UrlHandler.kt | Maps Tasks.URL into Task.url. |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/handler/OrganizerHandler.kt | Maps Tasks.ORGANIZER into Task.organizer (as mailto: URI) with invalid-URI handling. |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/handler/LocationHandler.kt | Maps Tasks.LOCATION into Task.location. |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/handler/GeoHandler.kt | Parses and maps Tasks.GEO into Task.geoPosition. |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/handler/DescriptionHandler.kt | Maps Tasks.DESCRIPTION into Task.description. |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/handler/ColorHandler.kt | Maps Tasks.TASK_COLOR into Task.color. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/tasks/handler/UrlHandlerTest.kt | Tests URL field mapping into Task. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/tasks/handler/OrganizerHandlerTest.kt | Tests organizer mapping, including invalid organizer input handling. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/tasks/handler/LocationHandlerTest.kt | Tests location field mapping into Task. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/tasks/handler/GeoHandlerTest.kt | Tests GEO parsing/mapping and invalid input handling. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/tasks/handler/DescriptionHandlerTest.kt | Tests description field mapping into Task. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/tasks/handler/ColorHandlerTest.kt | Tests color field mapping into Task. |
…dlers # Conflicts: # lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/DmfsTaskProcessor.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.