Backport: Add spent/created_txouts to SPK and Keychain TxOut indexes#2161
Open
notmandatory wants to merge 4 commits intobitcoindevkit:release/chain-0.23.xfrom
Open
Backport: Add spent/created_txouts to SPK and Keychain TxOut indexes#2161notmandatory wants to merge 4 commits intobitcoindevkit:release/chain-0.23.xfrom
notmandatory wants to merge 4 commits intobitcoindevkit:release/chain-0.23.xfrom
Conversation
1 task
notmandatory
force-pushed
the
backport/send_recvd_txouts
branch
from
0b23c50 to
5561c3f
Compare
Collaborator
|
@notmandatory You can cherry-pick this b95e3cf, it should solve the MSRV issues. |
notmandatory
force-pushed
the
backport/send_recvd_txouts
branch
3 times, most recently
from
e9464cf to
fb00dd4
Compare
Member
Author
|
I rebased this whole PR on #2155 so it can be merged after that one. |
Collaborator
…indexes Implement sent_and_received_txouts methods on SpkTxOutIndex and KeychainTxOutIndex. These methods return actual TxOut structs allowing callers to access complete transaction output information including script pubkeys and values.
Return tuple of (index, TxOut) in sent_and_received_txouts methods to identify which input/output positions the TxOuts correspond to in the original transaction.
…eychain indexes Implement sent_txouts and created_txouts methods on SpkTxOutIndex and KeychainTxOutIndex. These methods return new SpentTxOut and CreatedTxOut structs allowing callers to access complete transaction information including script pubkeys, values, and spk index.
notmandatory
force-pushed
the
backport/send_recvd_txouts
branch
from
fb00dd4 to
a8fda13
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #2081 from
masterbranch torelease/chain-0.23.x.Notes to the reviewers
This is a non-breaking change that only adds the functions and structs described below.
Changelog notice
Added
Checklists
All Submissions:
New Features: