Update Wallet to 2.3.0 and other deps

[tvpeter]

Description

This PR updates the Wallet api to v2.3.0 and other dependencies.

Fixes #243

Changelog notice

• Update bdk_wallet to v2.3.0
• Add WalletEvents to the project
• Update bdk_bitcoind_rpc to v0.22.0
• Update bdk_electrum to v0.23.2
• Update bdk_kyoto to v0.15.4

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[tvpeter]

@notmandatory, I’m wondering if we should update our signing approach since the current method is deprecated. If we choose to proceed with the update, we will need to add miniscript as a separate dependency, as the version exported from the Wallet (v2.3.0) is 12.3.1. We require at least version 13.0.0. Or should we postpone this update until a later version?

[notmandatory]

@notmandatory, I’m wondering if we should update our signing approach since the current method is deprecated. If we choose to proceed with the update, we will need to add miniscript as a separate dependency, as the version exported from the Wallet (v2.3.0) is 12.3.1. We require at least version 13.0.0. Or should we postpone this update until a later version?

Good question. I've created bitcoindevkit/bdk_wallet#405 to revert the deprecating of the signer mod. The new PSBT signer probably won't be available until bdk_wallet 3.1.

[va-an]

Related #243.

[va-an]

Blocked by #252.

[tvpeter]

Blocked by #252.

Hi @va-an, could you please verify that you tagged the correct PR? Thank you!

[va-an]

Blocked by #252.

Hi @va-an, could you please verify that you tagged the correct PR? Thank you!

All correct. I've also reproduced error from PR's CI build in my local run just pre-push:

error[E0061]: this method takes 1 argument but 2 arguments were supplied
    --> src/payjoin/mod.rs:605:30
     |
 605 |   ...                   .check_payment(
     |                          ^^^^^^^^^^^^^
...
 618 | / ...                       |outpoint| {
 619 | | ...                           let utxo = self.wallet.get_utxo(outpoint);
 620 | | ...                           match utxo {
 621 | | ...                               Some(_) => Ok(false),
...    |
 624 | | ...                       }
     | |___________________________- unexpected argument #2 of type `{closure@src/payjoin/mod.rs:618:33: 618:43}`
     |
note: method defined here
    --> /home/vaan/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/payjoin-1.0.0-rc.2/src/core/receive/v2/mod.rs:1262:12
     |
1262 |     pub fn check_payment(
     |            ^^^^^^^^^^^^^
help: remove the extra argument
     |
 617 -                                 },
 618 -                                 |outpoint| {
 619 -                                     let utxo = self.wallet.get_utxo(outpoint);
 620 -                                     match utxo {
 621 -                                         Some(_) => Ok(false),
 622 -                                         None => Ok(true),
 623 -                                     }
     |

I've applied the fix from #252 to my local code to verify that it helps.

[va-an]

@tvpeter #252 is merged now, so this should be fine now.
Could you rebase on master? Other PRs will likely need to rebase on top of this once it's merged.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.97%. Comparing base (07fd32f) to head (4a41057).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/utils.rs	0.00%	30 Missing ⚠️
src/handlers.rs	0.00%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   11.13%   10.97%   -0.16%     
==========================================
  Files           8        8              
  Lines        2488     2524      +36     
==========================================
  Hits          277      277              
- Misses       2211     2247      +36     

Flag	Coverage Δ
rust	10.97% <0.00%> (-0.16%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.