Skip to content

PATCH: fix(files): use bulk delete methods for documents and folders#627

Merged
NicolasRichel merged 2 commits intoreleasefrom
fix/bulk-delete-documents
Feb 26, 2026
Merged

PATCH: fix(files): use bulk delete methods for documents and folders#627
NicolasRichel merged 2 commits intoreleasefrom
fix/bulk-delete-documents

Conversation

@NicolasRichel
Copy link
Member

@NicolasRichel NicolasRichel commented Feb 26, 2026

https://platform-dev-bulk-delete-documents.bimdata.io/

Description

We now use the new bulk delete methods to delete folders and documents.

This allows us to delete all files at once using only one request (instead of one request per file before).

Types of changes

  • Bug fix (non-breaking change which fixes an issue) DON'T FORGET TO SEND THE PR INTO RELEASE
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have tested my code.
  • My code add or change i18n tokens
  • I want to run the tests for the commits of this PR

@NicolasRichel NicolasRichel self-assigned this Feb 26, 2026
@NicolasRichel NicolasRichel force-pushed the fix/bulk-delete-documents branch from a93bb7f to 300079d Compare February 26, 2026 10:29
@NicolasRichel NicolasRichel changed the base branch from develop to release February 26, 2026 10:30
@NicolasRichel NicolasRichel force-pushed the fix/bulk-delete-documents branch from 300079d to d4f3649 Compare February 26, 2026 10:37
Copy link
Member

@RomainMou RomainMou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When deleting only file, it also do a bulk delete on folder without any ID in the data
Same for when deleting only folder, it also call bulk_destroy_history without any id.

Image

@NicolasRichel
Copy link
Member Author

When deleting only file, it also do a bulk delete on folder without any ID in the data
Image

Nice catch, just fixed it.

@NicolasRichel NicolasRichel merged commit 868df69 into release Feb 26, 2026
3 checks passed
@NicolasRichel NicolasRichel deleted the fix/bulk-delete-documents branch February 26, 2026 14:50
Bimdata-io pushed a commit that referenced this pull request Feb 27, 2026
## [1.3.5](v1.3.4...v1.3.5) (2026-02-27)

### chore

* bump @bimdata/viewer@2.16.3 from Github Actions [skip e2e] ([7fedf5c](7fedf5c))

### PATCH

* fix(bcf): use new post method for topics export ([eb8830f](eb8830f))
* fix(files): use bulk delete methods for documents and folders (#627) ([868df69](868df69)), closes [#627](#627)
@Bimdata-io
Copy link
Contributor

🎉 This PR is included in version 1.3.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants