Feature/model ged by LrxGaelle · Pull Request #625 · bimdata/platform

LrxGaelle · 2026-02-25T14:59:23Z

https://platform-dev-model-ged.bimdata.io

Description

This PR introduces two improvements in the GED:

Replace type sorting with type filtering
Add create models, create photospheres, and remove models actions based on multi-selection

Types of changes

Bug fix (non-breaking change which fixes an issue) DON'T FORGET TO SEND THE PR INTO RELEASE
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

My code follows the code style of this project.
I have tested my code.
My code add or change i18n tokens
I want to run the tests for the commits of this PR

…dels

Amoki · 2026-02-27T14:00:53Z

src/components/specific/files/files-manager/FilesManager.vue

+      if (!files?.length) return;
+      try {
+        selection.value = selection.value.map((f) => {
+          if (files.includes(f)) return { ...f, nature: "Model" };


Do we need to rebuild a selection ?
Maybe we can just change f.nature = "Model" and Vue reactivity works

Amoki · 2026-02-27T14:03:14Z

src/components/specific/files/files-manager/FilesManager.vue

        loadingFileIds.value = loadingFileIds.value.filter((id) => id !== file.id);
      }
    };
+    const createModelFromFiles = async (files, type) => {


rename files so we can know what are these files

Copilot

Pull request overview

This PR updates the GED files UI to replace “type” sorting with “type” filtering, and adds multi-selection actions to create models/photospheres or remove models.

Changes:

Replace “type” column sorting with filtering in folder and all-files tables, and compute a displayable type value for filtering.
Add multi-selection actions in the files action bar and implement bulk create-model/create-photosphere/remove-model flows in FilesManager.
Add i18n tokens for plural notifications and model/photosphere labels, and display model/photosphere info in the filename cell.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/i18n/lang/fr.json	Adds new FileNameCell labels and plural/bulk notifications in French.
src/i18n/lang/en.json	Adds new FileNameCell labels and plural/bulk notifications in English.
src/components/specific/files/folder-table/columns.js	Switches “type” column from sortable to filterable.
src/components/specific/files/folder-table/FoldersTable.vue	Feeds formatted rows (with computed `type`) to enable “type” filtering.
src/components/specific/files/files-table/file-name-cell/FileNameCell.vue	Adds model/photosphere indicator tooltip/icon and related logic.
src/components/specific/files/files-manager/files-action-bar/FilesActionBar.vue	Adds bulk actions (create models/photospheres, remove models) for multi-selection.
src/components/specific/files/files-manager/FilesManager.vue	Implements bulk create/remove handlers and loading state propagation.
src/components/specific/files/all-files-table/columns.js	Switches “type” column to filterable (removes sort function).
src/components/specific/files/all-files-table/AllFilesTable.vue	Adds type filter UI, improves selection handling, and formats rows to include a computed `type`.
src/components/specific/files/all-files-table/AllFilesTable.scss	Adds missing positioning styling for the “type” header/filter container.

Comments suppressed due to low confidence (3)

src/components/specific/files/all-files-table/AllFilesTable.vue:330

When fileExtension(file.name) returns an empty string (no extension), the current logic produces type: "" (because optional chaining still calls replace on ""). Add an explicit fallback so extensionless documents show t("t.file") (and folders show t("t.folder")).

            : file.name
              ? fileExtension(file.name)?.replace(".", "").toUpperCase()
              : t("t.file"),

src/components/specific/files/all-files-table/AllFilesTable.vue:371

The header checkbox uses a length equality check against displayedListFiles. With filters, selection may contain items not currently displayed, which forces an indeterminate state even if all displayed rows are selected. Compute this by checking whether every displayedListFiles item is selected (by id) instead of comparing lengths.

    const mainSelectionCheckboxValue = computed(() => {
      if (props.selection.length === 0) {
        return false;
      } else if (props.selection.length === displayedListFiles.value.length) {
        return true;

src/components/specific/files/files-manager/files-action-bar/FilesActionBar.vue:96

isModel is imported but never used in this component. Removing the unused import will avoid lint/build warnings and keep the module dependencies accurate.

import { computed } from "vue";
import { useToggle } from "../../../../../composables/toggle.js";
import { useUser } from "../../../../../state/user.js";
import { isFolder } from "../../../../../utils/file-structure.js";
import { isConvertible, isConvertibleToPhotosphere, isModel } from "../../../../../utils/models.js";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T14:24:11Z

src/components/specific/files/files-manager/files-action-bar/FilesActionBar.vue

+    const canConvertAllToModel = computed(() =>
+      props.files.every(
+        (file) => !isFolder(file) && isConvertible(file) && file.nature === "Document",
+      ),
+    );
+    const canConvertAllToPhotosphere = computed(() =>
+      props.files.every(
+        (file) => !isFolder(file) && isConvertibleToPhotosphere(file) && file.nature === "Document",
+      ),


canConvertAllToModel / canConvertAllToPhotosphere are based on props.files.every(...), which evaluates to true when props.files is empty. This will show the create-model/photosphere actions even when nothing is selected. Add a props.files.length > 0 guard (similar to canRemoveAllModels).

Suggested change

const canConvertAllToModel = computed(() =>

props.files.every(

(file) => !isFolder(file) && isConvertible(file) && file.nature === "Document",

),

);

const canConvertAllToPhotosphere = computed(() =>

props.files.every(

(file) => !isFolder(file) && isConvertibleToPhotosphere(file) && file.nature === "Document",

),

const canConvertAllToModel = computed(

() =>

props.files.length > 0 &&

props.files.every(

(file) => !isFolder(file) && isConvertible(file) && file.nature === "Document",

),

);

const canConvertAllToPhotosphere = computed(

() =>

props.files.length > 0 &&

props.files.every(

(file) =>

!isFolder(file) &&

isConvertibleToPhotosphere(file) &&

file.nature === "Document",

),

Copilot · 2026-02-27T14:24:11Z

src/components/specific/files/files-manager/FilesManager.vue

+        selection.value = selection.value.map((f) => {
+          if (files.includes(f)) return { ...f, nature: "Model" };
+          return f;
+        });
+
+        loadingFileIds.value.push(...files.map((f) => f.id));


createModelFromFiles optimistically sets selection items to nature: "Model" before the API calls and never rolls back on failure. If a conversion fails (or the request rejects), the UI can show items as models even though the backend state didn't change. Apply the UI update only after success, or revert it based on per-file results.

Copilot · 2026-02-27T14:24:12Z

src/components/specific/files/files-manager/FilesManager.vue

+        if (!modelsToDelete.length) return;
+


If modelsToDelete.length is 0, the function returns early after having already changed selection and added loadingFileIds. This leaves UI state modified even though no delete occurred. Consider checking modelsToDelete before mutating UI state, or ensure you revert selection/loading before returning.

Copilot · 2026-02-27T14:24:12Z

src/components/specific/files/files-table/file-name-cell/FileNameCell.vue

+            position="right"
+            class="flex items-center"
+          >
+            <BIMDataIconSetAsModel v-if="file.nature === 'Model' || file.type === 'PHOTOSPHERE'" />


The photosphere marker uses file.type === 'PHOTOSPHERE', but type is now used elsewhere as the displayed file extension ("PDF", etc.). Photosphere documents (model_type === 'PHOTOSPHERE' with nature === 'Document') won’t render the icon, making the tooltip effectively unreachable. Use file.model_type / MODEL_TYPE.PHOTOSPHERE (or isModel(file)) instead.

Suggested change

<BIMDataIconSetAsModel v-if="file.nature === 'Model' || file.type === 'PHOTOSPHERE'" />

<BIMDataIconSetAsModel v-if="file.nature === 'Model' || file.model_type === 'PHOTOSPHERE'" />

Copilot · 2026-02-27T14:24:12Z

src/components/specific/files/files-manager/FilesManager.vue

+        selection.value = selection.value.map((f) => {
+          if (files.includes(f)) return { ...f, nature: "Model" };
+          return f;
+        });


files.includes(f) relies on object identity; selection items and the files arg may be different object instances with the same id (especially now that some tables map/format rows). Compare by id instead (e.g., build a Set of ids) to ensure the correct rows are updated.

Copilot · 2026-02-27T14:24:12Z

src/components/specific/files/files-manager/FilesManager.vue

+        selection.value = selection.value.map((f) => {
+          if (files.includes(f)) return { ...f, nature: "Document" };
+          return f;
+        });
+        loadingFileIds.value.push(...files.map((f) => f.id));


removeModels optimistically mutates selection before deleting models and uses files.includes(f) (object identity). This can fail to update the intended rows and can also leave the UI in an incorrect state if deletion fails. Use id-based matching and update/revert selection based on actual deletion outcomes.

Copilot · 2026-02-27T14:24:13Z

src/components/specific/files/all-files-table/AllFilesTable.vue

+      return props.allFiles.map((file) => ({
+        ...file,
+        type:
+          file.nature === "folder"


file.nature === "folder" doesn’t match the codebase’s folder nature ("Folder" / isFolder(file)). This will misclassify folders and produce incorrect type values for filtering/display. Use isFolder(file) or FILE_TYPE.FOLDER here.

Suggested change

file.nature === "folder"

file.nature === "Folder"

Amoki · 2026-02-27T14:41:08Z

src/components/specific/files/files-manager/FilesManager.vue

      }
    };

+    const removeModels = async (files) => {


if files === selection.value, we can just use selection.value

Amoki · 2026-02-27T14:44:15Z

src/components/specific/files/files-manager/FilesManager.vue

+          if (files.includes(f)) return { ...f, nature: "Document" };
+          return f;
+        });
+        loadingFileIds.value.push(...files.map((f) => f.id));


Can we use a boolean to disable the button instead of maintaining the list of ids ?

LrxGaelle self-assigned this Feb 25, 2026

LrxGaelle force-pushed the feature/model-ged branch from 41192e4 to 07c4b52 Compare February 26, 2026 09:56

LrxGaelle changed the title ~~[WIP] Feature/model ged~~ Feature/model ged Feb 27, 2026

LrxGaelle requested a review from NicolasRichel February 27, 2026 10:46

LrxGaelle added 6 commits February 27, 2026 13:52

add filter by type instead of sorting

e40fe39

add create models & create photospheres with ged selection

c5c2a84

fix canRemoveAllModels method

6873dec

fix canConvertAllToModel, canConvertAllToPhotosphere & canRemoveAllMo…

c2e4dea

…dels

add model or photosphere tag into FileNameCell

703cd54

create notification for create and remove photospheres & models

e0cd896

LrxGaelle force-pushed the feature/model-ged branch from 6d3537d to e0cd896 Compare February 27, 2026 12:54

LrxGaelle removed the request for review from NicolasRichel February 27, 2026 12:59

LrxGaelle changed the title ~~Feature/model ged~~ [WIP] Feature/model ged Feb 27, 2026

fix display model info for folder

aedae74

LrxGaelle requested a review from NicolasRichel February 27, 2026 13:08

LrxGaelle changed the title ~~[WIP] Feature/model ged~~ Feature/model ged Feb 27, 2026

Amoki reviewed Feb 27, 2026

View reviewed changes

Amoki requested a review from Copilot February 27, 2026 14:18

Copilot started reviewing on behalf of Amoki February 27, 2026 14:18 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Amoki requested changes Feb 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/model ged#625

Feature/model ged#625
LrxGaelle wants to merge 7 commits intodevelopfrom
feature/model-ged

LrxGaelle commented Feb 25, 2026 •

edited

Loading

Uh oh!

Amoki Feb 27, 2026

Uh oh!

Amoki Feb 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Amoki Feb 27, 2026

Uh oh!

Amoki Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<BIMDataIconSetAsModel v-if="file.nature === 'Model' \|\| file.type === 'PHOTOSPHERE'" />
	<BIMDataIconSetAsModel v-if="file.nature === 'Model' \|\| file.model_type === 'PHOTOSPHERE'" />

Conversation

LrxGaelle commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Checklist

Uh oh!

Amoki Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Amoki Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Amoki Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Amoki Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LrxGaelle commented Feb 25, 2026 •

edited

Loading