add the ability to toggle attribute refs between multiple values#595
Closed
hesxenon wants to merge 1 commit intobigskysoftware:masterfrom
Closed
add the ability to toggle attribute refs between multiple values#595hesxenon wants to merge 1 commit intobigskysoftware:masterfrom
hesxenon wants to merge 1 commit intobigskysoftware:masterfrom
Conversation
hesxenon
changed the title
Contributor
|
Hey, that's a great idea! Did you make any progress on this? |
Author
|
@zyriab kinda, I think I've made all necessary adjustments but I couldn't get the test suite to even start and then work happened and I lost track of it. Will resume work on this in the near future. |
Contributor
Awesome! |
Author
|
that's good to know so I can at least be a bit confident in my changes, but
I meant automated with mocha-headless 😅
…On Tue, Feb 25, 2025, 15:20 Arthur Wallendorff ***@***.***> wrote:
@zyriab <https://github.com/zyriab> kinda, I think I've made all
necessary adjustments but I couldn't get the test suite to even start and
then work happened and I lost track of it. Will resume work on this in the
near future.
Awesome!
To run the test suite you just have to open the tests/index.html in a
browser :)
—
Reply to this email directly, view it on GitHub
<#595 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOHZTSY3OJ4FVB3SSSDQJL2RR3ZTAVCNFSM6AAAAABTR3UKCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBSGEZTCNJSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: zyriab]*zyriab* left a comment (bigskysoftware/_hyperscript#595)
<#595 (comment)>
@zyriab <https://github.com/zyriab> kinda, I think I've made all
necessary adjustments but I couldn't get the test suite to even start and
then work happened and I lost track of it. Will resume work on this in the
near future.
Awesome!
To run the test suite you just have to open the tests/index.html in a
browser :)
—
Reply to this email directly, view it on GitHub
<#595 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOHZTSY3OJ4FVB3SSSDQJL2RR3ZTAVCNFSM6AAAAABTR3UKCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBSGEZTCNJSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Ah yeah, can't help with that, sorry 😅 |
Contributor
|
Cleaning up PRs, please reopen for reconsideration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the language with a syntax to toggle a given attribute ref between two values.
Note: I'll try not to make toggling between an arbitrary amount of values impossible