Correctly check the ENABLE_HTTPS_PROXY variable#386
Open
pslldq wants to merge 1 commit intobigbluebutton:developfrom
Open
Correctly check the ENABLE_HTTPS_PROXY variable#386pslldq wants to merge 1 commit intobigbluebutton:developfrom
pslldq wants to merge 1 commit intobigbluebutton:developfrom
Conversation
Correctly check the ENABLE_HTTPS_PROXY variable to avoid setting the variable to false triggering an error about a missing LETSENCRYPT_EMAIL. This reuses the default variable expansion used later in the docker command to determine the actual value and check that it's not the default value of false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly check the ENABLE_HTTPS_PROXY variable to avoid setting the variable to false triggering an error about a missing LETSENCRYPT_EMAIL. This reuses the default variable expansion used later in the docker command to determine the actual value and check that it's not the default value of false.