-
-
Notifications
You must be signed in to change notification settings - Fork 7
Free of syn #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free of syn #66
Changes from all commits
8b016a5
2a53c02
5f78d36
8103d92
af0c2ef
c2a41f4
649da91
b36a53d
a81b90a
01b2de7
9bc828e
21312e9
56a666f
3bbf5e1
42bb6de
90b2d94
269aa04
00a9556
83eca7d
05af7c6
2cf29ae
9dc660b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ homepage = "https://github.com/bevyengine/variadics_please" | |
| repository = "https://github.com/bevyengine/variadics_please" | ||
| license = "MIT OR Apache-2.0" | ||
| keywords = ["bevy", "variadics", "docs"] | ||
| rust-version = "1.81.0" | ||
| rust-version = "1.83.0" | ||
| categories = ["rust-patterns"] | ||
| exclude = ["tools/", ".github/"] | ||
| documentation = "https://docs.rs/variadics_please" | ||
|
|
@@ -20,9 +20,8 @@ alloc = [] | |
| proc-macro = true | ||
|
|
||
| [dependencies] | ||
| syn = "2.0" | ||
| quote = "1.0" | ||
| proc-macro2 = "1.0" | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| unsynn = "0.3" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The primary complaint here is that we're increasing supply-chain risk by doing this: single maintainer, relatively small name, new-ish crate. That said, given the counterfactual and meaningfully improved compile time benchmarks I'm happy to take this trade!
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I'm primarily basing my own trust on Amos (fasterthanlime), since he is a big name and is heavily pushing this crate. |
||
|
|
||
| [dev-dependencies] | ||
| static_assertions = "1.1" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ allow = [ | |
| "MIT-0", | ||
| "Unlicense", | ||
| "Zlib", | ||
| "Unicode-3.0", | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This just allows unicode symbols to be redistributed freely. Seems alright :) |
||
| ] | ||
|
|
||
| exceptions = [ | ||
|
|
@@ -73,6 +74,8 @@ deny = [ | |
| { name = "android-activity", deny-multiple-versions = true }, | ||
| { name = "glam", deny-multiple-versions = true }, | ||
| { name = "raw-window-handle", deny-multiple-versions = true }, | ||
| # keep syn entirely out of tree, since we use unsynn instead | ||
| { name = "syn" }, | ||
| ] | ||
|
|
||
| [sources] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked it up, this is the minimal version that supports rust-lang/rust#128183, which
unsynnuses