Fix/login progress and 2fa#4
Open
velazcod wants to merge 2 commits into
Open
Conversation
Add warning() method to ProgressReporter class to fix AttributeError when activities_iterator.py calls self.progress.warning() during sync.
Pass prompt_mfa callback to AuthClient.login() so users with 2FA enabled are prompted for their MFA code. Previously, prompt_mfa defaulted to None which caused login to silently fail for 2FA accounts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error for:
Failed to initialize: 'ProgressReporter' object has no attribute 'warning' Error: 'ProgressReporter' object has no attribute 'warning'And a silent failure during login when the account has 2FA enabled:
Password: Connecting to Garmin Connect... Endpoint shared by multiple metrics: /wellness-service/wellness/dailyStress/{date} used by stress and body_battery Failed to load activities batch at offset 0: Authentication required for fetching Activities: Not authenticated. Please login first.