Skip to content

Filter Extension Requests by Student from Enrollments Page#324

Merged
cycomachead merged 4 commits intoberkeley-cdss:mainfrom
cs169:data-search-query-upstream
Mar 17, 2026
Merged

Filter Extension Requests by Student from Enrollments Page#324
cycomachead merged 4 commits intoberkeley-cdss:mainfrom
cs169:data-search-query-upstream

Conversation

@alxstx
Copy link
Copy Markdown
Contributor

@alxstx alxstx commented Feb 28, 2026

Changes

Adds the ability for instructors to click a student's name on the Enrollments page and navigate to the Requests page with the table automatically filtered to show only that student's requests. This connects the existing controller logic (@search_query) and JavaScript search functionality by adding the missing data-search-query attribute to the requests table view.

Testing

  • Added RSpec controller tests verifying @search_query is correctly assigned from params[:search] and defaults to nil when absent.
  • Added a Cucumber integration test (@javascript) that creates a request for a student, navigates to Enrollments as a teacher, clicks the student's name, and asserts the Requests page loads with the search filter pre-populated.
  • Added step definitions for clicking a student name link, verifying the search filter is active, and seeding request test data via FactoryBot.
  • All tests pass (26 RSpec examples, 2 Cucumber scenarios / 15 steps).

Documentation

No documentation required. The feature is a UI enhancement to existing pages with no new configuration or setup needed.

@superconductor-for-github
Copy link
Copy Markdown

superconductor-for-github Bot commented Feb 28, 2026

@alxstxSuperconductor finishedView implementation


Standing by for instructions.

@cycomachead cycomachead self-requested a review March 3, 2026 18:38
Copy link
Copy Markdown
Contributor

@cycomachead cycomachead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, this looks good. Will want to look into the failing cuke test, but otherwise will merge soon!

And I should see "User 3"
And I should see "User 4"
And I should see "User 5"
And I should see "User 5"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but there's more whitespace than necessary after this scenario

Copy link
Copy Markdown
Contributor

@cycomachead cycomachead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this looks good.

@cycomachead
Copy link
Copy Markdown
Contributor

I am a little confused why GitHub is currently showing me 0 files changed.

@cycomachead cycomachead merged commit 4ee296c into berkeley-cdss:main Mar 17, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants