Auto extended requests by gobears01 · Pull Request #306 · berkeley-cdss/flextensions

gobears01 · 2026-02-20T01:38:08Z

General Info

Client wants a feature where instructors can enable extended automatic extensions for students with extenuating circumstances. The feature has been divided into three user stories to be accomplished effectively:

UI (add a “Approve extended requests?” switch for instructor console)
UI (add a “Approve extended requests?” switch from instructor console) cs169/flextensions#309
Update student’s backend database when instructor toggles “Approve extended requests?"
Update student’s backend database when instructor toggles “Approve extended requests?" cs169/flextensions#310
When a DSP student requests an extension, it should be approved automatically based on extended accommodations
When a DSP student requests an extension, it should be approved automatically based on extended accommodations cs169/flextensions#311

Project Board Tracker

Changes

Adds ability to automatically approve extended requests from subset of students and corresponding UI

Testing

I added Rspec and cucumber tests for instructors' actions (toggling the button should update the database)
I added Rspec tests to make sure it works from the DSP students side.

Documentation

There's a existing textbox that describes the input form that instructors use to set the auto extended days.

See berkeley-cdss#275 https://canvas.instructure.com/doc/api/learning_object_dates.html#method.learning_object_dates.show:~:text=GET%20/api/v1/courses/%3Acourse_id/assignments/%3Aassignment_id/date_details

Add two API endpoints for fixing assignment due dates

…issing allow_extended_requests

filter test

data-search-query attribute to requests table for search filtering

- Fix double blank line in request.rb eligible_for_auto_approval? - Fix missing newline at EOF in enrollments.feature - Add specs for auto_approval_eligible_for_course? with extended days (zero standard days but positive extended days, both zero) - Add specs for eligible_for_auto_approval? edge cases: boundary (exactly max days), both days zero, no enrollment record fallback, max_auto_approve limit with extended requests - Add controller spec for non-existent enrollment (RecordNotFound) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add missing tests and fixes for auto extended requests

gobears01 · 2026-02-27T19:55:59Z

Dear professor @armandofox and professor @cycomachead,

Basim and I have finished the feature and this passed all the tests both in cucumber and Rspecs. Your review is appreciated. Thank you!

Anthony

Filter Extension Requests by Student from Enrollments Page

cycomachead

Some followups.

This looks great.

Two main things, which I'd suggest doing on the same branch, then opening a new PR to your local repo.

I think we'll need to add a little tooltip to the table row header to indicate what the setting means
when the AJAX request is successful, I think we need to have a flash message (in green) that says "Enabled extended automatic approvals for [student name]"
Or for failures "Failed to enable ..." (in red).

the flash messages could be a new PR if you'd like. I think they'd need to be done in JS and we'd probably want an additional test to ensure the text is shown (at least for success)

cycomachead · 2026-03-04T01:01:25Z

app/controllers/user_to_courses_controller.rb

+  def toggle_allow_extended_requests
+    @enrollment = @course.user_to_courses.find(params[:id])
+
+    unless @role == 'instructor'


Checks like this seem a little brittle / unclear in the authorization.

Does it work to use the ensure_instructor_role method as a before_action?
Or I see the issue might be needing to return JSON?

If it needs to be its own method, I would extract this logic to a before_action that just lives in this controller for now. And if so, I think it'd be worth writing @enrollment.course_admin? or .staff? -- in this app we generally don't want only instructors to make changes.

cycomachead · 2026-03-04T01:02:05Z

app/controllers/user_to_courses_controller.rb

+
+    unless @role == 'instructor'
+      Rails.logger.error "Role #{@role} does not have permission to toggle allow_extended_requests"
+      flash.now[:alert] = 'You do not have permission to perform this action.'


Can we add "You must be an instructor or Lead TA." if we're going to use the course_admin? method?

cycomachead · 2026-03-04T01:05:01Z

app/javascript/controllers/enrollments_controller.js

+		const allowExtended = checkbox.checked;
+
+		try {
+			const token = document.querySelector('meta[name="csrf-token"]')?.content || '';


Fine for now, though if we do more AJAX-y things, I think we should write some fetchWithToken method or something that shared this logic.

cycomachead · 2026-03-04T01:06:54Z

app/models/request.rb

    auto_approve(lms_facade_from_user)
  end

  def auto_approval_eligible_for_course?


Realizing this method totally belongs somewhere else, but we can leave it for now.

cycomachead · 2026-03-04T01:15:53Z

app/models/request.rb

  def auto_approval_eligible_for_course?
    return false if course&.course_settings.blank?

    course.course_settings.enable_extensions &&


Suggested change

course.course_settings.enable_extensions &&

course.course_settings.automatic_approval_enabled?

Let's go ahead and definite on course_settings

def automatic_approval_enabled? return false unless enable_extensions? auto_approve_days.positive? || auto_approve_extended_request_days.positive? end

I realized I was actually wrong about not needing () in class... because yeah, there's a weird case:

irb(main):010:0> false && false || true => true irb(main):011:0> false && (false || true) => false irb(main):012:0>

So rather than need () we can also just move the method and use 2 or 3 lines and that's just more clear.

cycomachead · 2026-03-04T01:20:36Z

app/models/request.rb

    return false if course&.course_settings.blank?
    return false unless course.course_settings.enable_extensions?
-    return false if course.course_settings.auto_approve_days.zero?
+    return false if course.course_settings.auto_approve_days.zero? && course.course_settings.auto_approve_extended_request_days.zero?


hmm. if we fix the above method, can't we just write return false unless course_settings.automatic_approval_enabled?

Though, better yet, since we do have the above method defined,

I might write:

def eligible_for_auto_approval? return false unless auto_approval_eligible_for_course? ...

I thought there should be a rubocop rule for this, but always leave a blank line between a guard clause a the next line of real code.

cycomachead · 2026-03-04T01:21:10Z

app/views/courses/enrollments.html.erb

                  <% end %>
                </span>
-                <% if enrollment.role.downcase == 'student' %>
+                <% if enrollment.student? %>


Thanks for the update! :)

cycomachead · 2026-03-04T01:32:50Z

app/views/courses/enrollments.html.erb

            <th class="text-center">Student ID</th>
            <th class="text-center">Email</th>
            <th class="text-center">Role</th>
+            <th class="text-center">Approved Extended?</th>


Suggested change

<th class="text-center">Approved Extended?</th>

<th class="text-center">

Extended Requests?

<a tabindex="0"

role="button"

data-bs-toggle="popover"

data-bs-trigger="focus"

data-bs-html="true"

data-bs-content="Allow students to have an additional window for automatically approved requests, such as for extenuating circumstances. Set the limit from <a href='<%= course_settings_path %>'>the settings page</a>."

aria-label="Help: additional request window settings">

<i class="fas fa-circle-question" aria-hidden="true"></i>

</a>

</th>

Can you see if this works (and reformat, or just reject this suggestion)

This is me using Claude + Bootstrap docs to generate the HTML
https://claude.ai/share/f1d9e7eb-52ca-4ff9-b387-76b246eea153

I didn't test, but it matched the smell test. I'd like a a little '?' in a circle next to the text in the head cell.

cycomachead · 2026-03-04T01:36:27Z

app/views/courses/enrollments.html.erb

              <td class="text-center"><%= enrollment.user.student_id %></td>
              <td class="text-center"><%= enrollment.user.email %></td>
              <td class="text-center"><%= enrollment.role.downcase.capitalize %></td>
+              <td class="justify-content-center align-content-center">


Suggested change

<td class="justify-content-center align-content-center">

<td

class="justify-content-center align-content-center"

data-order="<%= enrollment.allow_extended_requests ? 1 : 0 %>"

>

This should allow the table to be sortable in data tables.

We will need to update the row's data-order value after the JSON request returns

cycomachead · 2026-03-04T01:37:21Z

app/javascript/controllers/enrollments_controller.js

+				throw new Error(data.error || 'Error updating enrollment');
+			}
+
+			console.log(`Enrollment ${enrollmentId} allow_extended_requests: ${allowExtended}`);


Let's not leave this in the production app. :)

Instead can we please add create a flash message, but maybe that's a followup.

gobears01 and others added 14 commits February 12, 2026 16:25

Some local changes for development

06fda77

Added UI for new approve extended extensions switch

ae372e1

Add two API endpoints for fixing assignment due dates

d8ece10

See berkeley-cdss#275 https://canvas.instructure.com/doc/api/learning_object_dates.html#method.learning_object_dates.show:~:text=GET%20/api/v1/courses/%3Acourse_id/assignments/%3Aassignment_id/date_details

Updated backend when using' Approved Extended Requests?' toggle

87681cf

Merge pull request #313 from cs169/add-new-api-scopes

e00f0ee

Add two API endpoints for fixing assignment due dates

Finished the course settings and approval logic for dsp

81ba7f2

undo changes to Ruby version

2400723

Reverted development changes to Gemfile

9ab1d1f

Fixed sync enrollments error where users were getting recreated and m…

657e5b9

…issing allow_extended_requests

Add tests for enrollments-to-requests search filter

36e9c4b

Add step definitions and test data for enrollments-to-requests

c47968d

filter test

Add

8255280

data-search-query attribute to requests table for search filtering

Added rspec and cucumber testing for DSP auto requests

f700f0e

gobears01 marked this pull request as ready for review February 26, 2026 20:26

Merge pull request #319 from cs169/basim/review-auto-extended-requests

bed1e14

Add missing tests and fixes for auto extended requests

Merge pull request #316 from cs169/data-search-query-branch

e37eb6d

Filter Extension Requests by Student from Enrollments Page

cycomachead self-requested a review March 2, 2026 19:48

gobears01 and others added 3 commits March 3, 2026 16:58

Addressing comments on pull request

bddf989

Update tests for students missing enrollment

1941690

Merge branch 'main' into auto-extended-requests

94b9d71

cycomachead requested changes Mar 4, 2026

View reviewed changes

	course.course_settings.enable_extensions &&
	course.course_settings.automatic_approval_enabled?

-            <th class="text-center">Approved Extended?</th>
+            <th class="text-center">
+               Extended Requests?
+               <a tabindex="0"
+   role="button"
+   data-bs-toggle="popover"
+   data-bs-trigger="focus"
+   data-bs-html="true"
+   data-bs-content="Allow students to have an additional window for automatically approved requests, such as for extenuating circumstances. Set the limit from <a href='<%= course_settings_path %>'>the settings page</a>."
+   aria-label="Help: additional request window settings">
+  <i class="fas fa-circle-question" aria-hidden="true"></i>
+</a>
+            </th>

Conversation

gobears01 commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

General Info

Changes

Testing

Documentation

Uh oh!

gobears01 commented Feb 27, 2026

Uh oh!

cycomachead left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gobears01 commented Feb 20, 2026 •

edited

Loading