Fix ASGI headers to use bytes instead of str#4
Merged
Conversation
The ASGI specification requires headers to be list[tuple[bytes, bytes]].
The asgi_scope_from_map() function was falling through to generic
conversion which decoded Erlang binaries as Python str instead of bytes.
This caused authentication failures and form parsing issues with
frameworks like Starlette and FastAPI, which search for headers using
bytes keys (e.g., b"content-type").
Changes:
- Add explicit header handling in asgi_scope_from_map()
- Convert header names and values using PyBytes_FromStringAndSize()
- Support both list [name, value] and tuple {name, value} formats
- Bump version to 1.6.1
Fixes #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strinstead ofbyteslist[tuple[bytes, bytes]]Fixes #1