Add benchmark aliases for multiple exact-match identifiers by Louisvranderick · Pull Request #742 · bencherdev/bencher

Louisvranderick · 2026-03-27T01:40:19Z

Summary

Add a new benchmark_alias table with UNIQUE(project_id, alias) and cascading foreign keys so benchmarks can keep multiple exact-match aliases over time.
Resolve benchmark NameId::Name by primary name or alias (single query with OR EXISTS), and validate alias uniqueness inside create/update write transactions to avoid TOCTOU races.
Expose aliases through API + generated types, wire CLI create/update --alias, and batch-load aliases in list/report paths to avoid N+1 query behavior.

Closes #674

Test plan

cargo fmt
cargo clippy -p bencher_schema -p api_projects -p bencher_cli --no-deps --all-targets --all-features -- -Dwarnings
cargo test -p bencher_schema model::project::benchmark
cargo check --no-default-features
cargo gen-types outputs committed (services/api/openapi.json, services/console/src/types/bencher.ts)

Made with Cursor

Add a `benchmark_alias` table so benchmarks can be resolved by alternative names in addition to their primary name, slug, or UUID. This lets users rename benchmarks over time without losing continuity. - New `benchmark_alias` migration with UNIQUE(project_id, alias) and cascading deletes - Split `benchmark.rs` into `benchmark/mod.rs` + `benchmark/alias.rs` - Single-query name resolution via OR + EXISTS in `from_name_id` - TOCTOU-safe alias validation inside write transactions - Batched alias loading to avoid N+1 in list and report endpoints - CLI `--alias` flag on `benchmark create` and `benchmark update` - Generated OpenAPI spec and TypeScript types updated Closes bencherdev#674 Made-with: Cursor

github-actions · 2026-03-27T02:07:29Z

Bencher Report

Branch	benchmark-alias
Testbed	ubuntu-22.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result microseconds (µs) (Result Δ%)	Upper Boundary microseconds (µs) (Limit %)
Adapter::Json	📈 view plot 🚷 view threshold	3.94 µs (+7.53%) Baseline: 3.66 µs	4.49 µs (87.78%)
Adapter::Magic (JSON)	📈 view plot 🚷 view threshold	4.13 µs (+14.13%) Baseline: 3.62 µs	4.52 µs (91.49%)
Adapter::Magic (Rust)	📈 view plot 🚷 view threshold	21.01 µs (-16.43%) Baseline: 25.14 µs	32.86 µs (63.95%)
Adapter::Rust	📈 view plot 🚷 view threshold	3.01 µs (+7.48%) Baseline: 2.80 µs	3.22 µs (93.57%)
Adapter::RustBench	📈 view plot 🚷 view threshold	2.98 µs (+6.67%) Baseline: 2.80 µs	3.22 µs (92.81%)
head_version_insert/batch/10	📈 view plot 🚷 view threshold	110.88 µs (+9.91%) Baseline: 100.88 µs	117.82 µs (94.11%)
head_version_insert/batch/100	📈 view plot 🚷 view threshold	252.03 µs (+5.56%) Baseline: 238.74 µs	263.96 µs (95.48%)
head_version_insert/batch/255	📈 view plot 🚷 view threshold	475.51 µs (+2.56%) Baseline: 463.65 µs	498.88 µs (95.31%)
head_version_insert/batch/50	📈 view plot 🚷 view threshold	170.22 µs (+5.15%) Baseline: 161.89 µs	182.14 µs (93.45%)
threshold_query/join/10	📈 view plot 🚷 view threshold	157.70 µs (+8.02%) Baseline: 145.99 µs	168.85 µs (93.40%)
threshold_query/join/20	📈 view plot 🚷 view threshold	170.44 µs (+6.08%) Baseline: 160.67 µs	187.60 µs (90.85%)
threshold_query/join/5	📈 view plot 🚷 view threshold	148.00 µs (+7.01%) Baseline: 138.31 µs	160.91 µs (91.97%)
threshold_query/join/50	📈 view plot 🚷 view threshold	213.72 µs (+5.86%) Baseline: 201.89 µs	231.43 µs (92.35%)

🐰 View full continuous benchmarking report in Bencher

epompeii

Thank you @Louisvranderick! Just took a cursory look.

epompeii · 2026-03-28T00:23:53Z

services/cli/src/parser/project/benchmark.rs

+    #[clap(long = "alias")]
+    pub aliases: Vec<BenchmarkName>,


The convention is to use the singular form for the field name (ie alias) even when it can be supplied multiple times.

Also using Option<Vec<BenchmarkName>> would be preferred to properly convey the semantics.

epompeii · 2026-03-28T00:35:41Z

lib/bencher_json/src/project/benchmark.rs

    pub slug: BenchmarkSlug,
    pub created: DateTime,
    pub modified: DateTime,
    pub archived: Option<DateTime>,
+    /// Additional exact-match strings (the primary [`Self::name`] is always a matcher).
+    #[serde(default)]
+    pub aliases: Vec<BenchmarkName>,


Conceptually, aliases should come after slug and before the timestamp fields.

epompeii · 2026-03-28T00:38:40Z

lib/bencher_schema/src/model/project/benchmark/mod.rs

+            NameId::Uuid(_) | NameId::Slug(_) => schema::benchmark::table
+                .filter(schema::benchmark::project_id.eq(project_id))
+                .filter(Self::eq_name_id(name_id))
+                .first::<Self>(conn)
+                .map_err(resource_not_found_err!(Benchmark, (project_id, name_id))),


If we're already matching here, it is a bit silly to then have to requery by NameId.

- CLI: singular alias with Option<Vec<BenchmarkName>>; preserve wire JSON - Reorder JsonBenchmark (aliases after slug); regenerate bencher.ts - Refactor QueryBenchmark::from_name_id; fix plus report/job priority handling - Fix benchmark list total_count error mapping; batch alias loading for GET list Made-with: Cursor

Louisvranderick · 2026-04-03T20:14:13Z

Pushed a follow-up commit (e680a56) that covers the review notes.

The CLI now uses a single alias flag with an optional list of names, and the JSON we send is the same as before. On the wire type, aliases sits right after slug, and the generated bencher.ts matches.

QueryBenchmark::from_name_id is spelled out explicitly (UUID, slug, primary name, then alias lookup) and the old helper macro is gone, with tests updated.

For plus / otel builds, priority and is_claimed are only threaded where the feature cfg allows, so bencher_schema compiles with plus again.

The benchmark list endpoint batch-loads aliases, and the name/search filters also match alias rows. I also fixed a copy-paste bug where list total_count errors were attributed to Plot instead of Benchmark.

Relying on CI for the full run.

Resolve conflicts in report/mod.rs and runner/job.rs: keep report idempotency from devel; align priority/otel cfg with QueryReport::process_results (plus+otel). Made-with: Cursor

github-actions · 2026-04-03T20:32:04Z

Bencher Report

Branch	benchmark-alias
Testbed	intel-v1

Click to view all benchmark results

Benchmark	Latency	Benchmark Result microseconds (µs) (Result Δ%)	Upper Boundary microseconds (µs) (Limit %)
Adapter::Json	📈 view plot 🚷 view threshold	4.57 µs (+0.46%) Baseline: 4.54 µs	4.63 µs (98.53%)
Adapter::Magic (JSON)	📈 view plot 🚷 view threshold	4.41 µs (-0.15%) Baseline: 4.42 µs	4.46 µs (98.79%)
Adapter::Magic (Rust)	📈 view plot 🚷 view threshold	25.12 µs (-0.09%) Baseline: 25.15 µs	26.52 µs (94.75%)
Adapter::Rust	📈 view plot 🚷 view threshold	3.36 µs (-0.34%) Baseline: 3.37 µs	3.45 µs (97.38%)
Adapter::RustBench	📈 view plot 🚷 view threshold	3.35 µs (-0.56%) Baseline: 3.37 µs	3.47 µs (96.54%)

🐰 View full continuous benchmarking report in Bencher

Made-with: Cursor

- Use pointer double-cast for libc::signal and document unsafe for function-casts-as-integer / fn_to_numeric_cast_any. - Drop stale crate-level expect(multiple_inherent_impl); lint no longer fires. Made-with: Cursor

Louisvranderick mentioned this pull request Mar 27, 2026

Add multiple aliases for a Benchmark #674

Open

epompeii requested changes Mar 28, 2026

View reviewed changes

Merge upstream/devel into benchmark-alias

0a4cf78

Resolve conflicts in report/mod.rs and runner/job.rs: keep report idempotency from devel; align priority/otel cfg with QueryReport::process_results (plus+otel). Made-with: Cursor

Louisvranderick added 2 commits April 3, 2026 17:39

chore: rustfmt report/mod.rs (fix CI Cargo Format)

7a67bd3

Made-with: Cursor

fix: satisfy Clippy 1.94 on macOS signal handler and bencher_client

1b4d464

- Use pointer double-cast for libc::signal and document unsafe for function-casts-as-integer / fn_to_numeric_cast_any. - Drop stale crate-level expect(multiple_inherent_impl); lint no longer fires. Made-with: Cursor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add benchmark aliases for multiple exact-match identifiers#742

Add benchmark aliases for multiple exact-match identifiers#742
Louisvranderick wants to merge 5 commits intobencherdev:develfrom
Louisvranderick:benchmark-alias

Louisvranderick commented Mar 27, 2026

Uh oh!

github-actions bot commented Mar 27, 2026

Uh oh!

epompeii left a comment

Uh oh!

epompeii Mar 28, 2026

Uh oh!

epompeii Mar 28, 2026

Uh oh!

epompeii Mar 28, 2026

Uh oh!

Louisvranderick commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Louisvranderick commented Mar 27, 2026

Summary

Test plan

Uh oh!

github-actions bot commented Mar 27, 2026

Bencher Report

Uh oh!

epompeii left a comment

Choose a reason for hiding this comment

Uh oh!

epompeii Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

epompeii Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

epompeii Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Louisvranderick commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bencher Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Apr 3, 2026 •

edited

Loading