Fixed bug with nested Run blocks#1
Open
brodie-roberts-ix wants to merge 1 commit intobenburkert:masterfrom
Open
Fixed bug with nested Run blocks#1brodie-roberts-ix wants to merge 1 commit intobenburkert:masterfrom
brodie-roberts-ix wants to merge 1 commit intobenburkert:masterfrom
Conversation
Author
|
Upon using this further I've found a second panic case once two such Run blocks are put consecutively. The panic is on line 91 of pbench.go and triggers when Run "F" returns. I can't figure this one out easily, so I'll just have to fall back to only nesting Runs 1 deep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using your package for a project I'm working on at work. I found a bug when nesting Run blocks, which can be reproduced like so:
This one-line change should fix the issue!