-
Notifications
You must be signed in to change notification settings - Fork 1
Support for Spring without Spring Boot #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pvdbosch
wants to merge
26
commits into
main
Choose a base branch
from
feature/spring-without-boot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
8ad1147
merge NoResourceFoundExceptionHandler into RoutingExceptionsHandler
pvdbosch 8ba5f31
don't use Spring Boot's @ConfigurationProperties
pvdbosch 663387b
[spring] specific java packages for server and client
pvdbosch ca4cd23
[spring] merge all spring common-* and *-core modules (WIP)
pvdbosch b69e65f
spring refactoring WIP:
pvdbosch ed3f0f0
spring refactoring WIP:
pvdbosch c654849
rename spring modules
pvdbosch bbba49f
minor cleanup
pvdbosch 1e4f78f
fix module names in jacoco module
pvdbosch 4881cc1
avoid exposing abstract classes to Spring users:
pvdbosch 9e46f35
add EnableProblemModule for use in non-Spring-Boot
pvdbosch aee5235
- javadoc fixes
pvdbosch 2080a17
instantiate beans within @Configuration classes instead of @Import of…
pvdbosch 693e8fd
remove abstract classes for customizers in spring module, bc they're …
pvdbosch 005f51c
change the way it-common-jakarta is generated, to improve integration…
pvdbosch 6039da7
[spring-only] add missing parameterNameProvider config for bean valid…
pvdbosch b18fa5e
add integration test for spring-without-boot
pvdbosch a277652
EnableProblemModule: use enum to configure Jackson version
pvdbosch 04b6033
update doc
pvdbosch a38c4f5
it-jakarta: transform beans.xml
pvdbosch 1b0622f
Merge branch 'main' into feature/spring-without-boot
pvdbosch e5a8e3a
Merge branch 'main' into feature/spring-without-boot
jpraet 570fc7c
Align minimal jackson3 version with the one in spring boot 4.0
pvdbosch a7f7e98
Cleanup referenced modules in bom and jacoco-aggregator
jpraet 9c34d86
Merge branch 'main' into feature/spring-without-boot
jpraet 9d5016f
Cleanup referenced modules in bom and jacoco-aggregator
jpraet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...thub/belgif/rest/problem/Application.java → ...b/belgif/rest/problem/it/Application.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...io/github/belgif/rest/problem/Client.java → ...github/belgif/rest/problem/it/Client.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package io.github.belgif.rest.problem; | ||
| package io.github.belgif.rest.problem.it; | ||
|
|
||
| public enum Client { | ||
|
|
||
|
|
||
2 changes: 1 addition & 1 deletion
2
...gif/rest/problem/ControllerInterface.java → .../rest/problem/it/ControllerInterface.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...rest/problem/OpenApiValidationConfig.java → ...t/problem/it/OpenApiValidationConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package io.github.belgif.rest.problem; | ||
| package io.github.belgif.rest.problem.it; | ||
|
|
||
| import java.util.Collections; | ||
|
|
||
|
|
||
14 changes: 7 additions & 7 deletions
14
.../problem/OpenApiValidationController.java → ...oblem/it/OpenApiValidationController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...roblemOpenApiValidationSpringBoot3IT.java → ...roblemOpenApiValidationSpringBoot3IT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
.../problem/RestProblemSpringBoot3ExtIT.java → ...oblem/it/RestProblemSpringBoot3ExtIT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could/should use the same approach for the other -jakarta modules in the project.
The old approach is indeed not very user-friendly from IDE / debugging point of view.
Maybe we should split this off to another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted to #312.