Fixes: Replace hardcoded maxlines to parameter#26
Open
manandharsudhir wants to merge 4 commits into
Open
Conversation
bdlukaa
requested changes
Feb 11, 2025
Owner
bdlukaa
left a comment
bdlukaa
left a comment
There was a problem hiding this comment.
Improve formatting with trailing commas.
Add documentation to the new properties.
| outerRadius: outerRadius ?? kDefaultOuterRadius, | ||
| textAlign: textAlign, | ||
| maxLines: 1, | ||
| maxLines: maxLines, |
Owner
There was a problem hiding this comment.
Suggested change
| maxLines: maxLines, | |
| maxLines: maxLines ?? 1, |
Comment on lines
+1
to
+4
| ## 0.5.1 | ||
| * fix: Added maxlines on parameters replacing hardcoded maxline | ||
|
|
||
|
|
Owner
There was a problem hiding this comment.
Suggested change
| ## 0.5.1 | |
| * fix: Added maxlines on parameters replacing hardcoded maxline | |
| ## 0.5.1 | |
| * fix: Added maxlines on parameters replacing hardcoded maxline |
Comment on lines
+376
to
+379
| final lineInfos = computeLines(text, | ||
| firstLinePadding: firstLinePadding, | ||
| innerLinePadding: innerLinePadding, | ||
| lastLinePadding: lastLinePadding); |
Owner
There was a problem hiding this comment.
Improve formatting:
Suggested change
| final lineInfos = computeLines(text, | |
| firstLinePadding: firstLinePadding, | |
| innerLinePadding: innerLinePadding, | |
| lastLinePadding: lastLinePadding); | |
| final lineInfos = computeLines(text, | |
| firstLinePadding: firstLinePadding, | |
| innerLinePadding: innerLinePadding, | |
| lastLinePadding: lastLinePadding, | |
| ); |
Comment on lines
+299
to
+305
| backgroundColor: backgroundColor ?? Colors.transparent, | ||
| text: painter, | ||
| innerRadius: innerRadius, | ||
| outerRadius: outerRadius, | ||
| firstLinePadding: firstLinePadding, | ||
| innerLinePadding: innerLinePadding, | ||
| lastLinePadding: lastLinePadding), |
Owner
There was a problem hiding this comment.
Suggested change
| backgroundColor: backgroundColor ?? Colors.transparent, | |
| text: painter, | |
| innerRadius: innerRadius, | |
| outerRadius: outerRadius, | |
| firstLinePadding: firstLinePadding, | |
| innerLinePadding: innerLinePadding, | |
| lastLinePadding: lastLinePadding), | |
| backgroundColor: backgroundColor ?? Colors.transparent, | |
| text: painter, | |
| innerRadius: innerRadius, | |
| outerRadius: outerRadius, | |
| firstLinePadding: firstLinePadding, | |
| innerLinePadding: innerLinePadding, | |
| lastLinePadding: lastLinePadding | |
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
after:
List which issues are fixed by this PR. You must list at least one issue.
Due to hardcoded maxline the text would always wrap on 1 line and others would be hidden hence passing maxlines through parameter.
Pre-launch Checklist
CHANGELOG.mdwith my changes