upgrade to Node.js 24#868
Conversation
panish16
requested review from
davemck513,
hfekete,
mengdong19,
ozamani9gh,
rarmitag and
stevenc987
as code owners
|
|
@panish16 You have two outstanding comments above before this PR can be merged. Also, please chase down the other reviewers for this code change -- another team (not Entities) owns this repo. Thanks. |
panish16
force-pushed
the
32835-nodejs
branch
3 times, most recently
from
3d75574 to
2543039
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
The code changes look fine.
This UI needs to be tested to verify that the sbc-common-components patch is still in place. See patch code for details of what to look for.
|
Temporary Url for review: https://namerequest-dev--pr-868-87yd6eiw.web.app |
There was a problem hiding this comment.
I ran the app at the preview URL and verified that both things that the sbc-common-components patch changes are running as expected.
Therefore, I approve this PR.
However, we should have at least another review (or more) from the Names Team before merging this PR. (And Names Team will have to add this UI to their next release.)
hfekete
left a comment
hfekete
left a comment
There was a problem hiding this comment.
I dont see any problems with this as long as it got tested, and it gets approved by at least one other teammate from Names team (as they will be releasing this)
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
Once again, the patch hash has been updated and it needs to be tested whether it will still work.
Anish, some time today I can walk you through what the patch changes and how to test it. Let me know.
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-868-87yd6eiw.web.app |
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
Once again, the pnpm lock file changes have been reverted, so the patch hash is unchanged (and I previously verified that the app works). So, once again, I approve this PR.
(My approval expires if this PR is changed again.)
5 participants
Issue #: https://app.zenhub.com/workspaces/sre-team-board-654d163c6817d80016102d9a/issues/gh/bcgov/entity/32835
Description of changes:
Update engines field in package.json to require Node.js >= 24.
Update GitHub Actions CI/CD workflows to use Node 24.
Align with modern runtime standards and ensure pipeline stability.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).