32792 - Add Validation for Custodian First Name in VD#4350
Merged
meawong merged 2 commits intobcgov:mainfrom May 4, 2026
Merged
32792 - Add Validation for Custodian First Name in VD#4350meawong merged 2 commits intobcgov:mainfrom
meawong merged 2 commits intobcgov:mainfrom
Conversation
loneil
requested changes
May 1, 2026
|
|
||
| else: | ||
| first_name = get_str(party, "/officer/firstName") | ||
| stripped_first_name = first_name.strip() |
Collaborator
There was a problem hiding this comment.
Tried quick locally on this branch and Llooks like can get through to this point without providing firstName at all so this excepts with AttributeError: 'NoneType' object has no attribute 'strip' and falls back with the generic handler.
Something like
if first_name is None or not first_name.strip(): could handle that
|
loneil
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32792
Description of changes:
validate_custodian_org_nameand add logic for VD party first name validationExamples:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).