fix(ci): pin test repository refs to stable commits#130
Closed
DerekRoberts wants to merge 1 commit intomainfrom
Closed
fix(ci): pin test repository refs to stable commits#130DerekRoberts wants to merge 1 commit intomainfrom
DerekRoberts wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the action’s CI test workflow by pinning external test repositories to known-good commit SHAs, avoiding upstream breakages (e.g., broken lockfiles) from impacting this repo’s CI.
Changes:
- Add a matrix-provided
branch(ref) forbcgov/nr-waste-plus, pinned to a stable commit SHA. - Provide a default
branch(ref) for other matrix entries (effectively pinningbcgov/quickstart-openshiftto a stable commit SHA).
Member
Author
|
Closing in favor of fixing the upstream issue in bcgov/quickstart-openshift#2668. We should always fix the root cause rather than pinning to old versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream breakage in
bcgov/quickstart-openshift(merged broken lockfile on April 7th) is causing all CI runs to fail duringnpm ci.This PR pins the test repositories to known good commits to protect this action's CI from upstream instability.
Changes
bcgov/quickstart-openshifttoa5b623e6(April 2nd)bcgov/nr-waste-plusto326778f5branchinput to the action call intests.yml