fix(ui): 1546 improved email validation#1605
Conversation
|
Temporary Url for review: https://strr-platform-dev--pr-1605-9vwirw0c.web.app |
There was a problem hiding this comment.
Just curious why tests are under platfom?
There was a problem hiding this comment.
Base web has no tests/unit folder so I figured the best thing to do is put them under platforms as there are barely any tests there. I'd be happy to put them somewhere else though if you think it's better! Let me know
There was a problem hiding this comment.
The platform has 80%+ test coverage. I would suggest putting email validation tests under host, since it is more freq changes.
There was a problem hiding this comment.
[out of scope]
This is a good candidate for implementing tests in the base-web nuxt app. Its not feasible to have the helper reusable code in base-web and having them being tested in consumer packages.
The Platform tests will fail unless you commit the strr-base-web changes first unless you were planning on overridding the CI checks
There was a problem hiding this comment.
Done, moved the tests under the host app.
|
|
Temporary Url for review: https://strr-hosts-dev--pr-1605-x5ceta8x.web.app |
4 participants
Issue:
Description of changes:
Improved email validation to better validate emails like foo@ba$.com for example
Unit tests for platforms pass:
It's just since it's in nuxt config, it still points to base layer which doesn't have the latest changes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License