BADGER-312: Segment timeline manifests unable to repeat segment requests#110
Open
BADGER-312: Segment timeline manifests unable to repeat segment requests#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest dash packager creates manifests which use
<SegmentTimeline />, the implementation ofTimelineSegmentsGetterresulted in the inability to repeat segment requests, freezing streams which use synthetic stalls.The cause was the use of
TimelineSegmentsGetterto progress the segment index, moving the onus of control away fromDashHandler- something otherSegmentGettersdon't do.TimelineSegmentsGetteruses a requested time to find a segment instead of an index which is the predominant means in other getters. This is down to the fact an MPD update can shift the timeline, making indexes an unreliable segment tracker.This PR refactors the
SegmentGetterinterface to loosen the coupling betweenDashHandlerandSegmentGetters, clarifying the roles of controller & getter.DashHandler's decision to repeat a segment request is now respected.