Skip to content

backport: feat(pypi): make whl_library reproducible under pipstar (#3589)#3631

Closed
rickeylev wants to merge 2 commits intobazel-contrib:mainfrom
rickeylev:release/1.9
Closed

backport: feat(pypi): make whl_library reproducible under pipstar (#3589)#3631
rickeylev wants to merge 2 commits intobazel-contrib:mainfrom
rickeylev:release/1.9

Conversation

@rickeylev
Copy link
Collaborator

No description provided.

rickeylev and others added 2 commits February 22, 2026 17:12
…b#3589)

This is testing the new API to make use of remote caching mechanisms.

Needs: bazelbuild/bazel#27634

---------

Co-authored-by: Richard Levasseur <rlevasseur@google.com>
(cherry picked from commit 06aa36d)
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a significant enhancement to the whl_library rule, enabling it to be marked as reproducible when processing Python wheels via pipstar's Starlark extraction mechanism. This change improves build consistency and reliability for Python dependencies managed by Bazel. Accompanying documentation updates clarify this new behavior and its associated version.

Highlights

  • whl_library Reproducibility: The _whl_library_impl function was updated to return rctx.repo_metadata(reproducible = True) when enable_pipstar and enable_pipstar_extract are true and repo_metadata is available, ensuring whl_library is marked as reproducible under pipstar.
  • Documentation Updates: The whl_library docstring was updated to reflect that it is marked as reproducible from version 1.9.0 when using Starlark for wheel extraction. Additionally, the versionadded tag in _features_typedef was changed from VERSION_NEXT_FEATURE to 1.9.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/features.bzl
    • Updated the versionadded tag for _features_typedef to 1.9.0.
  • python/private/pypi/whl_library.bzl
    • Modified _whl_library_impl to return rctx.repo_metadata(reproducible = True) under specific conditions related to pipstar extraction.
    • Extended the whl_library docstring to document its reproducibility when using Starlark for wheel parsing, effective from version 1.9.0.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports a feature to make the whl_library repository rule reproducible when using pipstar. The changes correctly add logic to call rctx.repo_metadata(reproducible = True) under the appropriate conditions. The associated documentation has also been updated to reflect this change. The implementation is clean and correct. I have no further feedback.

@rickeylev rickeylev deleted the release/1.9 branch February 23, 2026 16:37
@rickeylev rickeylev restored the release/1.9 branch February 23, 2026 16:38
@rickeylev rickeylev deleted the release/1.9 branch February 23, 2026 20:18
@rickeylev rickeylev restored the release/1.9 branch February 23, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants