chore: factor release note checking into separate script#3628
Open
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
Open
chore: factor release note checking into separate script#3628rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
rickeylev
force-pushed
the
chore.split.version.marker.check
branch
from
241bea7 to
3ed9c0d
Compare
dougthor42
approved these changes
Feb 23, 2026
| # Update our local state so the grep command below searches what we expect | ||
| git checkout "$TAG" | ||
|
|
||
| # Exclude dot directories, specifically, this file so that we don't |
Collaborator
There was a problem hiding this comment.
[Optional, non-blocking] It might be prudent to call check_version_markers.sh from this script.
- Removes the extra step in the release flow (I'm not sure what the GH step overhead is)
- There's no risk of forgetting to check for
VERSION_NEXTmarkers (if this create_archive_and_notes.sh` script is ever called outside of CI).
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
aignas
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make it easier to check for missing version markers by running the script directly