feat: Add comprehensive webhook subscription support#102
Merged
Conversation
- Add createWebhookSubscription, listWebhookSubscriptions, deleteWebhookSubscription methods to Client - Implement webhook subscription methods in REST service and ServiceInterface - Add Webhook helper class with event processing and validation utilities - Include comprehensive test coverage for all webhook functionality - Add example files demonstrating webhook usage - Update README with webhook integration documentation Author: Jennifer Martinez Closes: basvandorst#99 (webhook functionality request)
- Fix PHP 8.4 nullable parameter deprecation warnings by adding explicit ? type hints - Fix return type errors in Client methods by updating test expectations - Fix webhook DELETE operation to return proper array structure for 204 responses - Update all nullable parameters across Client, ServiceInterface, REST, and Stub classes - Ensure all 204 tests pass with proper array assertions All 204 tests now pass without deprecation warnings or errors.
Collaborator
|
Hi Jennifer, thanks for your contribution. Code looks good. I didn't extensively test this, but since it is completely new functionality and nobody is currently using it I'm inclined to merge. Thanks also for the php compatibility fixes. In the future I'd rather receive corrections like these in a separate PR, as it's quite a big review already. |
vredeling
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Jennifer Martinez
Closes: #99 (webhook functionality request)