Added _NET_WM_MOVERESIZE handling for the move case#1183
Added _NET_WM_MOVERESIZE handling for the move case#1183Jeffrey-P-McAteer wants to merge 3 commits intobaskerville:masterfrom
Conversation
…tion wm_resize_node in case anyone wants to let windows resize themselves.
…ET_WM_MOVERESIZE requests
| #define _NET_WM_MOVERESIZE_SIZE_TOPLEFT 0 | ||
| #define _NET_WM_MOVERESIZE_SIZE_TOP 1 | ||
| #define _NET_WM_MOVERESIZE_SIZE_TOPRIGHT 2 | ||
| #define _NET_WM_MOVERESIZE_SIZE_RIGHT 3 | ||
| #define _NET_WM_MOVERESIZE_SIZE_BOTTOMRIGHT 4 | ||
| #define _NET_WM_MOVERESIZE_SIZE_BOTTOM 5 | ||
| #define _NET_WM_MOVERESIZE_SIZE_BOTTOMLEFT 6 | ||
| #define _NET_WM_MOVERESIZE_SIZE_LEFT 7 | ||
| #define _NET_WM_MOVERESIZE_MOVE 8 /* movement only */ | ||
| #define _NET_WM_MOVERESIZE_SIZE_KEYBOARD 9 /* size via keyboard */ | ||
| #define _NET_WM_MOVERESIZE_MOVE_KEYBOARD 10 /* move via keyboard */ | ||
| #define _NET_WM_MOVERESIZE_CANCEL 11 /* cancel operation */ |
There was a problem hiding this comment.
These constants are already defined in xcb_ewmh.h.
There was a problem hiding this comment.
Thank you, I updated the changes in d7a31ad. I don't know if github can do a PR as a squashed merge but I'm fine re-committing the 3 changes as 1 because it makes the history cleaner.
…h.h> and renamed the constants to match in events.c
|
I get the following warnings using GCC: |
|
Hey, what's the current state of this? The patch works for me. I think having the _NET_WM_MOVERESIZE atom enabled is kinda important, at least for me :] |
|
@deeedob I remember there being community flak about code style when I originally worked on this change, which is why it was never merged in. I have since abandoned the change and moved back to using |
Added _NET_WM_MOVERESIZE handling for the move case and an empty function wm_resize_node in case anyone wants to let windows resize themselves.
This change adds the ability for programs like MPV to request that they be moved, see #864.
Tested by doing: